Merge pull request #2520 from strictdoc-project/stanislaw/remove_passthrough

chore(export/html): drop the legacy 'passthrough' command, migrate itests to export --formats=sdoc

Author: stanislaw

strictdoc/cli/cli_arg_parser.py

@@ -220,10 +220,6 @@ def is_debug_mode(self) -> bool:
     def is_about_command(self) -> bool:
         return str(self.args.command) == "about"
 
-    @property
-    def is_passthrough_command(self) -> bool:
-        return str(self.args.command) == "passthrough"
-
     @property
     def is_export_command(self) -> bool:
         return str(self.args.command) == "export"

strictdoc/cli/command_parser_builder.py

@@ -124,7 +124,6 @@ def build(self) -> SDocArgumentParser:
         self.add_manage_command(command_subparsers)
         self.add_import_command(command_subparsers)
         self.add_version_command(command_subparsers)
-        self.add_passthrough_command(command_subparsers)
         self.add_dump_command(command_subparsers)
         self.add_diff_command(command_subparsers)
 
@@ -404,100 +403,6 @@ def add_version_command(
             formatter_class=formatter,
         )
 
-    @staticmethod
-    def add_passthrough_command(
-        parent_command_parser: "argparse._SubParsersAction[SDocArgumentParser]",
-    ) -> None:
-        # Passthrough command is kept for backwards compatibility. It will
-        # internally be handled as export --formats sdoc.
-        command_parser_passthrough = parent_command_parser.add_parser(
-            "passthrough",
-            help="Read an SDoc file, then output it again. Deprecated, use "
-            "strictdoc export --formats sdoc instead.",
-            formatter_class=formatter,
-        )
-        command_parser_passthrough.add_argument(
-            "input_paths",
-            type=str,
-            nargs="+",
-            help="One or more folders with *.sdoc files",
-        )
-        command_parser_passthrough.add_argument(
-            "--output-dir",
-            type=str,
-            help="A directory where to output the SDoc files to.",
-        )
-        # FIXME: --filter-requirements will be removed in 2026.
-        command_parser_passthrough.add_argument(
-            "--filter-nodes",
-            "--filter-requirements",
-            dest="filter_nodes",
-            type=str,
-            help="Filter which requirements will be exported.",
-        )
-        command_parser_passthrough.add_argument(
-            "--view",
-            type=str,
-            help="Choose which view will be exported.",
-        )
-
-        # Hidden default values to make deprecated passthrough parser compatible
-        # with SDocArgsParser.get_export_config.
-        command_parser_passthrough.add_argument(
-            "--project-title", const=None, help=argparse.SUPPRESS
-        )
-        command_parser_passthrough.add_argument(
-            "--formats",
-            default=["sdoc"],
-            help=argparse.SUPPRESS,
-        )
-        command_parser_passthrough.add_argument(
-            "--fields",
-            default=None,
-            help=argparse.SUPPRESS,
-        )
-        command_parser_passthrough.add_argument(
-            "--generate-bundle-document",
-            default=False,
-            help=argparse.SUPPRESS,
-        )
-        command_parser_passthrough.add_argument(
-            "--no-parallelization",
-            default=False,
-            help=argparse.SUPPRESS,
-        )
-        command_parser_passthrough.add_argument(
-            "--enable-mathjax",
-            default=False,
-            help=argparse.SUPPRESS,
-        )
-        command_parser_passthrough.add_argument(
-            "--included-documents",
-            default=False,
-            help=argparse.SUPPRESS,
-        )
-        command_parser_passthrough.add_argument(
-            "--reqif-profile",
-            default=None,
-            help=argparse.SUPPRESS,
-        )
-        command_parser_passthrough.add_argument(
-            "--reqif-multiline-is-xhtml",
-            default=False,
-            help=argparse.SUPPRESS,
-        )
-        command_parser_passthrough.add_argument(
-            "--reqif-enable-mid",
-            default=False,
-            help=argparse.SUPPRESS,
-        )
-        command_parser_passthrough.add_argument(
-            "--chromedriver",
-            default=None,
-            help=argparse.SUPPRESS,
-        )
-        add_config_argument(command_parser_passthrough)
-
     @staticmethod
     def add_dump_command(
         parent_command_parser: "argparse._SubParsersAction[SDocArgumentParser]",

strictdoc/cli/main.py

@@ -49,12 +49,7 @@ def _main(parallelizer: Parallelizer, parser: SDocArgsParser) -> None:
 
     project_config: ProjectConfig
 
-    if parser.is_passthrough_command or parser.is_export_command:
-        if parser.is_passthrough_command:
-            print(  # noqa: T201
-                "warning: passthrough is deprecated, use strictdoc "
-                "export --formats sdoc instead."
-            )
+    if parser.is_export_command:
         export_config: ExportCommandConfig = parser.get_export_config()
         try:
             export_config.validate()

tests/integration/features/commands/bypass/00_basic_requirement_test/test.itest

@@ -1,4 +1,4 @@
-RUN: %strictdoc passthrough %S --view PRINT_VIEW --output-dir %T
+RUN: %strictdoc export %S --formats=sdoc --view PRINT_VIEW --output-dir %T
 RUN: %cat %T/sdoc/input.sdoc | filecheck %s --check-prefix CHECK-SDOC
 
 CHECK-SDOC: REQ-1

tests/integration/features/commands/bypass/01_empty_document_with_freetext/test.itest

@@ -1,4 +1,4 @@
-RUN: %strictdoc passthrough %S --output-dir %T
+RUN: %strictdoc export %S --formats=sdoc --output-dir %T
 RUN: %cat %T/sdoc/input.sdoc | filecheck %s --check-prefix=CHECK-SDOC
 
 CHECK-SDOC: REQ-1