Merge pull request #203 from streamr-dev/dataunion-linting

DataUnion Linting

Author: timoxley

.github/workflows/nodejs.yml

@@ -48,6 +48,8 @@ jobs:
         run: npm ci
       - name: npm run eslint
         run: npm run eslint
+      - name: test-types
+        run: npm run test-types
 
   test:
     name: Test Unit using Node ${{ matrix.node-version }}

package.json

@@ -27,6 +27,7 @@
     "eslint": "eslint --cache-location=node_modules/.cache/.eslintcache/ '*/**/*.{js,ts}'",
     "test": "jest --detectOpenHandles",
     "test-unit": "jest test/unit --detectOpenHandles",
+    "test-types": "tsc --noEmit --project ./tsconfig.test.json",
     "coverage": "jest --coverage",
     "test-integration": "jest --forceExit test/integration",
     "test-integration-no-resend": "jest --forceExit --testTimeout=10000 --testPathIgnorePatterns='resend|Resend' --testNamePattern='^((?!(resend|Resend|resent|Resent|gap|Gap)).)*$' test/integration/*.test.js",

src/rest/DataUnionEndpoints.ts

@@ -26,12 +26,12 @@ describe('DataUnionEndPoints', () => {
     const tokenMainnet = new Contract(config.clientOptions.tokenAddress, Token.abi, tokenAdminWallet)
 
     afterAll(async () => {
-        await providerMainnet.removeAllListeners()
-        await providerSidechain.removeAllListeners()
+        providerMainnet.removeAllListeners()
+        providerSidechain.removeAllListeners()
         await adminClient.ensureDisconnected()
     })
 
-    const streamrClientCleanupList = []
+    const streamrClientCleanupList: StreamrClient[] = []
     afterAll(async () => Promise.all(streamrClientCleanupList.map((c) => c.ensureDisconnected())))
 
     beforeAll(async () => {
@@ -51,7 +51,7 @@ describe('DataUnionEndPoints', () => {
 
     // fresh dataUnion for each test case, created NOT in parallel to avoid nonce troubles
     const adminMutex = new Mutex()
-    async function deployDataUnionSync(testName) {
+    async function deployDataUnionSync(testName: string) {
         let dataUnion: DataUnion
         await adminMutex.runExclusive(async () => {
             const dataUnionName = testName + Date.now()
@@ -74,7 +74,7 @@ describe('DataUnionEndPoints', () => {
                 }
             )
         })
-        return dataUnion
+        return dataUnion!
     }
 
     describe('Admin', () => {

test/integration/dataunion/DataUnionEndpoints.test.ts

@@ -15,7 +15,7 @@ const createMockAddress = () => '0x000000000000000000000000000' + Date.now()
 
 describe('DataUnion deployment', () => {
 
-    let adminClient
+    let adminClient: StreamrClient
 
     beforeAll(async () => {
         log(`Connecting to Ethereum networks, config = ${JSON.stringify(config)}`)

test/integration/dataunion/deploy.test.ts

@@ -8,8 +8,9 @@
     "outDir": "dist",
     "strict": true,
     "esModuleInterop": true,
-    "resolveJsonModule": true
+    "resolveJsonModule": true,
+    "moduleResolution": "node"
   },
-  "include": ["src/**/*"],
+  "include": ["src/**/*", "contracts/*"],
   "exclude": ["node_modules", "dist"]
-}
+}

tsconfig.json

@@ -0,0 +1,5 @@
+{
+  "extends": "./tsconfig.json",
+  "include": ["src/**/*", "contracts/**/*", "test/**/*"],
+  "exclude": ["node_modules", "dist", "test/legacy/*"]
+}