Skip to content
This repository was archived by the owner on Dec 21, 2021. It is now read-only.

Commit 6d9e9cb

Browse files
committed
Remove no longer needed webpack export default workaround.
1 parent 4cd05c4 commit 6d9e9cb

File tree

1 file changed

+0
-13
lines changed

1 file changed

+0
-13
lines changed

webpack.config.js

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -75,19 +75,6 @@ module.exports = (env, argv) => {
7575
output: {
7676
libraryTarget: 'umd2',
7777
filename: libraryName + '.web.js',
78-
// NOTE:
79-
// exporting the class directly
80-
// `export default class StreamrClient {}`
81-
// becomes:
82-
// `window.StreamrClient === StreamrClient`
83-
// which is correct, but if we define the class and export separately,
84-
// which is required if we do interface StreamrClient extends …:
85-
// `class StreamrClient {}; export default StreamrClient;`
86-
// becomes:
87-
// `window.StreamrClient = { default: StreamrClient, … }`
88-
// which is wrong for browser builds.
89-
// see: https://github.com/webpack/webpack/issues/706#issuecomment-438007763
90-
libraryExport: 'default', // This fixes the above.
9178
library: 'StreamrClient',
9279
},
9380
resolve: {

0 commit comments

Comments
 (0)