Skip to content

Commit e26edd5

Browse files
committed
feat(json-crdt): 🎸 improve encoding constants
1 parent e1d9c03 commit e26edd5

File tree

2 files changed

+3
-10
lines changed

2 files changed

+3
-10
lines changed

src/json-crdt/file/File.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export class File implements Printable {
2020
const [view, metadata, model, history, ...frontier] = components;
2121
const modelFormat = metadata[1];
2222
let decodedModel: Model<any> | null = null;
23-
if (model && modelFormat !== FileModelEncoding.None) {
23+
if (model) {
2424
const isSidecar = modelFormat === FileModelEncoding.SidecarBinary;
2525
if (isSidecar) {
2626
const decoder = new SidecarDecoder();
@@ -63,7 +63,7 @@ export class File implements Printable {
6363

6464
public serialize(params: types.FileSerializeParams = {}): types.FileWriteSequence {
6565
const view = this.model.view();
66-
const metadata: types.FileMetadata = [{}, FileModelEncoding.SidecarBinary];
66+
const metadata: types.FileMetadata = [{}, FileModelEncoding.Auto];
6767
let model: Uint8Array | unknown | null = null;
6868
const modelFormat = params.model ?? 'sidecar';
6969
switch (modelFormat) {
@@ -75,22 +75,18 @@ export class File implements Printable {
7575
break;
7676
}
7777
case 'binary': {
78-
metadata[1] = FileModelEncoding.StructuralBinary;
7978
model = this.model.toBinary();
8079
break;
8180
}
8281
case 'compact': {
83-
metadata[1] = FileModelEncoding.StructuralCompact;
8482
model = new StructuralEncoderCompact().encode(this.model);
8583
break;
8684
}
8785
case 'verbose': {
88-
metadata[1] = FileModelEncoding.StructuralVerbose;
8986
model = new StructuralEncoderVerbose().encode(this.model);
9087
break;
9188
}
9289
case 'none': {
93-
metadata[1] = FileModelEncoding.None;
9490
model = null;
9591
break;
9692
}

src/json-crdt/file/constants.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
export const enum FileModelEncoding {
2-
None = 0,
2+
Auto = 0,
33
SidecarBinary = 1,
4-
StructuralBinary = 5,
5-
StructuralCompact = 6,
6-
StructuralVerbose = 7,
74
}

0 commit comments

Comments
 (0)