Fix critical bugs: parameter reassignment, unsafe non-null assertions, NaN checks, and Array.isArray usage

Co-authored-by: streamich <9773803+streamich@users.noreply.github.com>

Author: Copilot

src/json-crdt-patch/codec/binary/Decoder.ts

@@ -49,7 +49,7 @@ export class Decoder extends CborDecoder<CrdtReader> {
     this.patchSid = clock.sid;
     const builder = (this.builder = new PatchBuilder(clock));
     const map = this.val();
-    if (map instanceof Array) builder.patch.meta = map[0];
+    if (Array.isArray(map)) builder.patch.meta = map[0];
     this.decodeOperations();
     return builder.patch;
   }

src/json-crdt-patch/codec/compact/encode.ts

@@ -12,7 +12,7 @@ const timestamp = (sid: number, ts: ITimestampStruct): types.CompactCodecTimesta
 
 const timespan = (sid: number, span: ITimespanStruct): types.CompactCodecTimespan => {
   const ts = timestamp(sid, span);
-  if (ts instanceof Array) {
+  if (Array.isArray(ts)) {
     ts.push(span.span);
     return ts;
   }

src/json-crdt/json-patch/JsonPatch.ts

@@ -160,7 +160,7 @@ export class JsonPatch<N extends JsonNode = JsonNode<any>> {
     if (!(node instanceof StrNode)) throw new Error('NOT_FOUND');
     const length = node.length();
     if (length <= pos) return;
-    const deletionLength = Math.min(len ?? str!.length, length - pos);
+    const deletionLength = Math.min(len ?? str.length, length - pos);
     const range = node.findInterval(pos, deletionLength);
     if (!range) throw new Error('OUT_OF_BOUNDS');
     this.builder().del(node.id, range);

src/json-crdt/model/api/nodes.ts

@@ -237,7 +237,7 @@ export class NodeApi<N extends JsonNode = JsonNode> implements Printable {
           index = ~~key;
           if (index + '' !== key) break ADD;
         }
-        if (index !== index) break ADD;
+        if (Number.isNaN(index)) break ADD;
         if (index < 0) index = 0;
         if (index > length) index = length;
         if (node instanceof ArrApi) node.ins(index, Array.isArray(value) ? value : [value]);
@@ -270,7 +270,7 @@ export class NodeApi<N extends JsonNode = JsonNode> implements Printable {
           index = ~~key;
           if (index + '' !== key) break REPLACE;
         }
-        if (index !== index || index < 0 || index > length) break REPLACE;
+        if (Number.isNaN(index) || index < 0 || index > length) break REPLACE;
         if (index === length) node.ins(index, [value]);
         else node.upd(index, value);
       } else if (node instanceof VecApi) node.set([[~~key, value]]);
@@ -297,7 +297,7 @@ export class NodeApi<N extends JsonNode = JsonNode> implements Printable {
           index = ~~key;
           if (index + '' !== key) break REMOVE;
         }
-        if (index !== index || index < 0 || index > len) break REMOVE;
+        if (Number.isNaN(index) || index < 0 || index > len) break REMOVE;
         node.del(index, Math.min(length, len - index));
       } else if (node instanceof VecApi) {
         node.set([[~~key, void 0]]);

src/json-size/msgpackSizeFast.ts

@@ -34,7 +34,7 @@ export const msgpackSizeFast = (value: unknown): number => {
     case 'boolean':
       return 1;
   }
-  if (value instanceof Array) return arraySize(value);
+  if (Array.isArray(value)) return arraySize(value);
   if (isUint8Array(value)) return 5 + value.length;
   if (value instanceof JsonPackValue) return (value as JsonPackValue).val.length;
   if (value instanceof JsonPackExtension) return 6 + (value as JsonPackExtension).val.length;

src/json-text/toTree.ts

@@ -4,14 +4,14 @@ import {stringify} from './stringify';
 const isPrimitive = (value: unknown): boolean => typeof value !== 'object' || value === null;
 const isOneLineValue = (value: unknown): boolean => {
   if (isPrimitive(value)) return true;
-  if (value instanceof Array && !value.length) return true;
+  if (Array.isArray(value) && !value.length) return true;
   if (value && typeof value === 'object' && !Object.keys(value).length) return true;
   return false;
 };
 const isSimpleString = (str: string) => /^[a-z0-9]+$/i.test(str);
 
 export const toTree = (value: unknown, tab: string = ''): string => {
-  if (value instanceof Array) {
+  if (Array.isArray(value)) {
     if (value.length === 0) return '[]';
     return printTree(
       tab,

src/util/strCnt.ts

@@ -2,10 +2,11 @@ export const strCnt = (needle: string, haystack: string, offset: number = 0): nu
   let cnt = 0;
   const needleLen = needle.length;
   if (needleLen === 0) return 0;
+  let currentOffset = offset;
   while (true) {
-    const index = haystack.indexOf(needle, offset);
+    const index = haystack.indexOf(needle, currentOffset);
     if (index < 0) return cnt;
     cnt++;
-    offset = index + needleLen;
+    currentOffset = index + needleLen;
   }
 };

src/util/throttle.ts

@@ -12,7 +12,9 @@ export const throttle = <F extends (...args: any[]) => void>(fn: F, ms: number =
     if (timer) return;
     timer = setTimeout(() => {
       timer = 0;
-      fn.apply(null, lastArgs!);
+      if (lastArgs) {
+        fn.apply(null, lastArgs);
+      }
     }, ms);
   }) as F;
   return [out, stop];