refactor(json-crdt-extensions): 💡 rename SplitSlice to MarkerSlice

Author: streamich

src/json-crdt-extensions/peritext/overlay/OverlayPoint.ts

@@ -2,7 +2,7 @@ import {Point} from '../rga/Point';
 import {compare} from '../../../json-crdt-patch/clock';
 import {OverlayRef, OverlayRefSliceEnd, OverlayRefSliceStart} from './refs';
 import {printTree} from 'sonic-forest/lib/print/printTree';
-import type {SplitSlice} from '../slice/SplitSlice';
+import type {MarkerSlice} from '../slice/MarkerSlice';
 import type {HeadlessNode} from 'sonic-forest/lib/types';
 import type {Printable} from '../../../util/print/types';
 import type {Slice} from '../slice/types';
@@ -157,7 +157,7 @@ export class OverlayPoint extends Point implements Printable, HeadlessNode {
    *
    * @param slice A marker (split slice).
    */
-  public addMarkerRef(slice: SplitSlice): void {
+  public addMarkerRef(slice: MarkerSlice): void {
     this.refs.push(slice);
     this.addMarker(slice);
   }

src/json-crdt-extensions/peritext/overlay/refs.ts

@@ -1,4 +1,4 @@
-import type {SplitSlice} from '../slice/SplitSlice';
+import type {MarkerSlice} from '../slice/MarkerSlice';
 import type {Slice} from '../slice/types';
 
 /**
@@ -8,7 +8,7 @@ import type {Slice} from '../slice/types';
  * and one to the end slice.
  */
 export type OverlayRef =
-  | SplitSlice // Ref to a *marker* slice
+  | MarkerSlice // Ref to a *marker*
   | OverlayRefSliceStart // Ref to the start of an annotation slice
   | OverlayRefSliceEnd; // Ref to the end of an annotation slice
 

src/json-crdt-extensions/peritext/slice/MarkerSlice.ts

@@ -0,0 +1,9 @@
+import {PersistedSlice} from './PersistedSlice';
+
+/**
+ * Represents a block split in the text, i.e. it is a *marker* that shows
+ * where a block was split.
+ *
+ * @deprecated
+ */
+export class MarkerSlice extends PersistedSlice {}

src/json-crdt-extensions/peritext/slice/PersistedSlice.ts

@@ -10,7 +10,6 @@ import {VecNode} from '../../../json-crdt/nodes';
 import {prettyOneLine} from '../../../json-pretty';
 import {validateType} from './util';
 import {s} from '../../../json-crdt-patch';
-import type {JsonNode} from '../../../json-crdt/nodes';
 import type {ITimestampStruct} from '../../../json-crdt-patch/clock';
 import type {ArrChunk} from '../../../json-crdt/nodes';
 import type {MutableSlice, SliceUpdateParams} from './types';

src/json-crdt-extensions/peritext/slice/Slices.ts

@@ -5,7 +5,7 @@ import {updateRga} from '../../../json-crdt/hash';
 import {CONST, updateNum} from '../../../json-hash';
 import {printTree} from '../../../util/print/printTree';
 import {SliceBehavior, SliceHeaderShift, SliceTupleIndex} from './constants';
-import {SplitSlice} from './SplitSlice';
+import {MarkerSlice} from './MarkerSlice';
 import {VecNode} from '../../../json-crdt/nodes';
 import {AvlMap} from 'sonic-forest/lib/avl/AvlMap';
 import type {Slice} from './types';
@@ -56,14 +56,14 @@ export class Slices implements Stateful, Printable {
     const txt = this.txt;
     const slice =
       behavior === SliceBehavior.Split
-        ? new SplitSlice(txt, txt.str, chunk, tuple, behavior, type, start, end)
+        ? new MarkerSlice(txt, txt.str, chunk, tuple, behavior, type, start, end)
         : new PersistedSlice(txt, txt.str, chunk, tuple, behavior, type, start, end);
     this.list.set(chunk.id, slice);
     return slice;
   }
 
-  public insSplit(range: Range, type: SliceType, data?: unknown): SplitSlice {
-    return this.ins(range, SliceBehavior.Split, type, data) as SplitSlice;
+  public insSplit(range: Range, type: SliceType, data?: unknown): MarkerSlice {
+    return this.ins(range, SliceBehavior.Split, type, data) as MarkerSlice;
   }
 
   public insStack(range: Range, type: SliceType, data?: unknown): PersistedSlice {
@@ -89,7 +89,7 @@ export class Slices implements Stateful, Printable {
     let slice = PersistedSlice.deserialize(txt, rga, chunk, tuple);
     // TODO: Simplify, remove `SplitSlice` class.
     if (slice.isSplit())
-      slice = new SplitSlice(txt, rga, chunk, tuple, slice.behavior, slice.type, slice.start, slice.end);
+      slice = new MarkerSlice(txt, rga, chunk, tuple, slice.behavior, slice.type, slice.start, slice.end);
     return slice;
   }