test(reactive-rpc): 💍 exit testing process after E2E tests are done

Author: streamich

.github/workflows/ci.yml

@@ -59,5 +59,4 @@ jobs:
           node-version: ${{ matrix.node-version }}
           cache: yarn
       - run: yarn install --frozen-lockfile
-      - run: yarn build:all
-      - run: PORT=9999 yarn test:reactive-rpc
+      - run: yarn test:reactive-rpc

package.json

@@ -47,7 +47,7 @@
     "build": "yarn build:es2020",
     "jest": "node -r ts-node/register ./node_modules/.bin/jest",
     "test": "jest --maxWorkers 7",
-    "test:all": "yarn lint && yarn test && yarn test:cli:pointer && yarn test:cli:patch && yarn test:cli:pack && yarn test:reactive-rpc && yarn demo:json-patch && yarn demo:json-pointer",
+    "test:all": "yarn lint && yarn test && yarn build:all && yarn test:cli:pointer && yarn test:cli:patch && yarn test:cli:pack && yarn test:reactive-rpc && yarn demo:json-patch && yarn demo:json-pointer",
     "test:ci": "yarn jest --maxWorkers 3 --no-cache",
     "test:cli": "yarn test:cli:pointer && yarn test:cli:patch && yarn test:cli:pack",
     "test:cli:pointer": "./bin/json-pointer-test.js ./bin/json-pointer.js",

src/reactive-rpc/common/rpc/__tests__/runApiTests.ts

@@ -4,7 +4,7 @@ import {of} from '../../util/of';
 import {RpcError} from '../caller';
 
 export interface ApiTestSetupResult {
-  client: Pick<StreamingRpcClient, 'call$'>;
+  client: Pick<StreamingRpcClient, 'call$' | 'stop'>;
 }
 
 export type ApiTestSetup = () => ApiTestSetupResult | Promise<ApiTestSetupResult>;
@@ -15,18 +15,21 @@ export const runApiTests = (setup: ApiTestSetup, params: {staticOnly?: boolean}
       const {client} = await setup();
       const result = await firstValueFrom(client.call$('ping', {}));
       expect(result).toBe('pong');
+      await client.stop();
     }, 15_000);
 
     test('can execute without payload', async () => {
       const {client} = await setup();
       const result = await firstValueFrom(client.call$('ping', undefined));
       expect(result).toBe('pong');
+      await client.stop();
     });
 
     test('can execute with unexpected payload', async () => {
       const {client} = await setup();
       const result = await firstValueFrom(client.call$('ping', 'VERY_UNEXPECTED'));
       expect(result).toBe('pong');
+      await client.stop();
     });
   });
 
@@ -35,6 +38,7 @@ export const runApiTests = (setup: ApiTestSetup, params: {staticOnly?: boolean}
       const {client} = await setup();
       const result = await firstValueFrom(client.call$('double', {num: 1.2}));
       expect(result).toEqual({num: 2.4});
+      await client.stop();
     });
 
     test('can execute two request in parallel', async () => {
@@ -44,13 +48,15 @@ export const runApiTests = (setup: ApiTestSetup, params: {staticOnly?: boolean}
       const [res1, res2] = await Promise.all([promise1, promise2]);
       expect(res1[0]).toEqual({num: 2});
       expect(res2[0]).toEqual({num: 4});
+      await client.stop();
     });
 
     test('throws error when validation fails', async () => {
       const {client} = await setup();
       const [, error] = await of(firstValueFrom(client.call$('double', {num: {}})));
       expect((error as RpcError).code).toBe('BAD_REQUEST');
       expect((error as RpcError).message).toBe('Payload .num field missing.');
+      await client.stop();
     });
   });
 
@@ -59,6 +65,7 @@ export const runApiTests = (setup: ApiTestSetup, params: {staticOnly?: boolean}
       const {client} = await setup();
       const [, error] = await of(firstValueFrom(client.call$('error', {})));
       expect(error).toMatchObject({message: 'this promise can throw'});
+      await client.stop();
     });
   });
 
@@ -67,6 +74,7 @@ export const runApiTests = (setup: ApiTestSetup, params: {staticOnly?: boolean}
       const {client} = await setup();
       const [, error] = await of(lastValueFrom(client.call$('streamError', {})));
       expect(error).toMatchObject({message: 'Stream always errors'});
+      await client.stop();
     });
   });
 
@@ -79,6 +87,7 @@ export const runApiTests = (setup: ApiTestSetup, params: {staticOnly?: boolean}
         commit: 'AAAAAAAAAAAAAAAAAAA',
         sha1: 'BBBBBBBBBBBBBBBBBBB',
       });
+      await client.stop();
     });
   });
 
@@ -89,6 +98,7 @@ export const runApiTests = (setup: ApiTestSetup, params: {staticOnly?: boolean}
       expect(result).toEqual({
         bar: 'aa',
       });
+      await client.stop();
     });
 
     test('throws on invalid data', async () => {
@@ -97,6 +107,7 @@ export const runApiTests = (setup: ApiTestSetup, params: {staticOnly?: boolean}
       expect(error).toMatchObject({
         message: '"foo" property missing.',
       });
+      await client.stop();
     });
   });
 
@@ -110,6 +121,7 @@ export const runApiTests = (setup: ApiTestSetup, params: {staticOnly?: boolean}
         expect(result).toEqual({
           bar: 'aa',
         });
+        await client.stop();
       });
 
       test('throws on invalid data', async () => {
@@ -118,6 +130,7 @@ export const runApiTests = (setup: ApiTestSetup, params: {staticOnly?: boolean}
         expect(error).toMatchObject({
           message: '"foo" property missing.',
         });
+        await client.stop();
       });
     });
   }

src/reactive-rpc/common/rpc/client/FetchRpcClient.ts

@@ -59,4 +59,6 @@ export class FetchRpcClient implements RpcClient {
   public notify(method: string, data: undefined | unknown): void {
     this.notify(method, data);
   }
+
+  public stop() {}
 }