Fix linting errors in config_loader and tests

- Fix unused loop variable in tool_config_loader.py (B007)
- Fix boolean comparison issues in test_agent_config.py (E712)
- Fix line length issues in structured output tests (E501)
- Fix unused variables in test files (F841)
- Fix blind exception assertion in schema registry test (B017)
- Add ValidationError import to schema registry test
- All tests passing (1010 passed, 55 warnings)

Author: vawsgit

src/strands/experimental/config_loader/tools/tool_config_loader.py

@@ -1519,7 +1519,7 @@ def _scan_module_for_tools(self, module: Any) -> List[Tuple[str, str]]:
         tools = []
 
         # Find @tool decorated functions
-        for name, obj in inspect.getmembers(module):
+        for _name, obj in inspect.getmembers(module):
             if isinstance(obj, DecoratedFunctionTool):
                 tools.append((obj.tool_name, "decorated"))
 

tests/strands/agent/test_agent_config.py

@@ -144,8 +144,8 @@ def test_agent_config_boolean_parameters(self):
 
         agent = Agent(config=config)
 
-        assert agent.record_direct_tool_call == False
-        assert agent.load_tools_from_directory == True
+        assert not agent.record_direct_tool_call
+        assert agent.load_tools_from_directory
 
     def test_agent_config_boolean_parameter_override(self):
         """Test that boolean parameters can be overridden."""
@@ -158,7 +158,7 @@ def test_agent_config_boolean_parameter_override(self):
         # Override boolean parameter
         agent = Agent(config=config, record_direct_tool_call=True)
 
-        assert agent.record_direct_tool_call == True
+        assert agent.record_direct_tool_call
 
     def test_agent_config_mixed_parameters(self):
         """Test mixing config and individual parameters."""
@@ -236,8 +236,8 @@ def test_agent_config_with_all_parameters(self):
         assert agent.name == "Comprehensive Agent"
         assert agent.description == "Agent with comprehensive configuration"
         assert agent.agent_id == "comprehensive_agent_001"
-        assert agent.record_direct_tool_call == False
-        assert agent.load_tools_from_directory == False
+        assert not agent.record_direct_tool_call
+        assert not agent.load_tools_from_directory
 
     @patch("strands.agent.agent.yaml.safe_load")
     def test_agent_config_yaml_load_error(self, mock_yaml_load):

tests/strands/experimental/config_loader/agent/test_agent_config_loader_structured_output.py

@@ -74,10 +74,13 @@ def test_load_agent_with_python_class_reference(self, mock_agent_class):
             "name": "test_agent",
             "model": "test_model",
             "system_prompt": "Test prompt",
-            "structured_output": "tests.strands.experimental.config_loader.agent.test_agent_config_loader_structured_output.TestBusinessModel",
+            "structured_output": (
+                "tests.strands.experimental.config_loader.agent."
+                "test_agent_config_loader_structured_output.TestBusinessModel"
+            ),
         }
 
-        agent = self.loader.load_agent(config)
+        self.loader.load_agent(config)
 
         # Verify structured output was configured with the Python class
         assert hasattr(mock_agent, "_structured_output_schema")
@@ -111,7 +114,7 @@ def test_load_agent_with_detailed_structured_output_config(self, mock_agent_clas
             },
         }
 
-        agent = self.loader.load_agent(config)
+        self.loader.load_agent(config)
 
         # Verify structured output was configured
         assert hasattr(mock_agent, "_structured_output_schema")
@@ -152,7 +155,7 @@ def test_load_agent_with_external_schema_file(self, mock_agent_class):
                 "structured_output": "Product",
             }
 
-            agent = self.loader.load_agent(config)
+            self.loader.load_agent(config)
 
             # Verify structured output was configured
             assert hasattr(mock_agent, "_structured_output_schema")
@@ -190,7 +193,7 @@ def test_load_agent_with_structured_output_defaults(self, mock_agent_class):
             },
         }
 
-        agent = self.loader.load_agent(config)
+        self.loader.load_agent(config)
 
         # Verify defaults were merged with specific config
         validation_config = mock_agent._structured_output_validation
@@ -225,10 +228,10 @@ def test_load_multiple_agents_with_shared_schemas(self, mock_agent_class):
         agent2_config = {**base_config, "name": "agent2", "model": "test_model", "structured_output": "SharedSchema"}
 
         # Load first agent (should load schemas)
-        agent1 = self.loader.load_agent(agent1_config)
+        self.loader.load_agent(agent1_config)
 
         # Load second agent (should reuse schemas)
-        agent2 = self.loader.load_agent(agent2_config)
+        self.loader.load_agent(agent2_config)
 
         # Both agents should have the same schema class
         assert hasattr(mock_agent1, "_structured_output_schema")
@@ -376,7 +379,7 @@ def test_convenience_method_creation(self, mock_agent_class):
             "structured_output": "CustomerProfile",
         }
 
-        agent = self.loader.load_agent(config)
+        self.loader.load_agent(config)
 
         # Verify convenience method was created
         assert hasattr(mock_agent, "extract_customerprofile")

tests/strands/experimental/config_loader/agent/test_integration.py

@@ -39,7 +39,9 @@ def test_load_agent_from_yaml_config(self):
         config = {
             "agent": {
                 "model": "us.anthropic.claude-3-7-sonnet-20250219-v1:0",
-                "system_prompt": "You're a helpful assistant. You can do simple math calculation, and tell the weather.",
+                "system_prompt": (
+                    "You're a helpful assistant. You can do simple math calculation, and tell the weather."
+                ),
                 "tools": [{"name": "weather_tool.weather"}],
             }
         }

tests/strands/experimental/config_loader/agent/test_schema_registry.py

@@ -7,7 +7,7 @@
 
 import pytest
 import yaml
-from pydantic import BaseModel
+from pydantic import BaseModel, ValidationError
 
 from strands.experimental.config_loader.agent.schema_registry import SchemaRegistry
 
@@ -351,5 +351,5 @@ def test_multiple_schemas_same_name(self):
         assert instance2.field2 == 42
 
         # Should not be able to create instance with old schema
-        with pytest.raises(Exception):  # ValidationError or AttributeError
+        with pytest.raises((ValidationError, AttributeError, TypeError)):
             model2(field1="test")

tests/strands/experimental/config_loader/graph/test_graph_config_loader.py

@@ -118,7 +118,7 @@ def test_serialize_graph(self):
         agent = Agent(name="test_agent", model="us.amazon.nova-lite-v1:0")
 
         # Mock the Graph creation since we need to avoid complex dependencies
-        with patch("strands.multiagent.graph.Graph") as MockGraph:
+        with patch("strands.multiagent.graph.Graph"):
             mock_graph = Mock()
 
             # Create a proper GraphNode with the agent