Fixing download url, adding package icon

stpatrick2016 · stpatrick2016 · commit afae9c8d7539 · 2018-08-30T13:42:06.000+03:00
diff --git a/vsts-extension/CompileMql5Task/CompileMql5.ps1 b/vsts-extension/CompileMql5Task/CompileMql5.ps1
@@ -1,7 +1,7 @@
 [CmdletBinding()]
 param()
 
-$compilerDownloadLink = ""
+$compilerDownloadLink = "https://github.com/stpatrick2016/mql5-compiler/blob/master/engine/metaeditor64.exe?raw=true"
 Trace-VstsEnteringInvocation $MyInvocation
 
 try {
@@ -30,6 +30,11 @@ try {
         {
             Write-Host "Metatrader compiler not found. Downloading from $compilerDownloadLink"
             [System.IO.Directory]::CreateDirectory([System.IO.Path]::GetDirectoryName($metaEditorPath)) | Out-Null
+
+            #fix the TLS issues, see here: https://stackoverflow.com/questions/41618766/powershell-invoke-webrequest-fails-with-ssl-tls-secure-channel
+            [Net.ServicePointManager]::SecurityProtocol = "tls12, tls11, tls"
+
+            #faster than Invoke-WebRequest, performance-wise
             (New-Object System.Net.WebClient).DownloadFile($compilerDownloadLink, $metaEditorPath)
         }
     }
diff --git a/vsts-extension/images/extension-icon.png b/vsts-extension/images/extension-icon.png
diff --git a/vsts-extension/vss-extension.json b/vsts-extension/vss-extension.json
@@ -2,7 +2,7 @@
     "manifestVersion": 1,
     "id": "stpatrick-tfs-build-tasks-mql5",
     "name": "MetaTrader 5 build tasks",
-    "version": "0.1.0",
+    "version": "0.1.1",
     "publisher": "philip-patrick",
     "targets": [
         {
@@ -14,7 +14,7 @@
         "Build and release"
     ],
     "icons": {
-        "default": "CompileMql5Task/icon.png"        
+        "default": "images/extension-icon.png"        
     },
     "files": [
         {

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`[CmdletBinding()]`
`2`	`2`	`param()`
`3`	`3`
`4`		`-$compilerDownloadLink = ""`
	`4`	`+$compilerDownloadLink = "https://github.com/stpatrick2016/mql5-compiler/blob/master/engine/metaeditor64.exe?raw=true"`
`5`	`5`	`Trace-VstsEnteringInvocation $MyInvocation`
`6`	`6`
`7`	`7`	`try {`
`@@ -30,6 +30,11 @@ try {`
`30`	`30`	`{`
`31`	`31`	`Write-Host "Metatrader compiler not found. Downloading from $compilerDownloadLink"`
`32`	`32`	`[System.IO.Directory]::CreateDirectory([System.IO.Path]::GetDirectoryName($metaEditorPath)) \| Out-Null`
	`33`	`+`
	`34`	`+ #fix the TLS issues, see here: https://stackoverflow.com/questions/41618766/powershell-invoke-webrequest-fails-with-ssl-tls-secure-channel`
	`35`	`+ [Net.ServicePointManager]::SecurityProtocol = "tls12, tls11, tls"`
	`36`	`+`
	`37`	`+ #faster than Invoke-WebRequest, performance-wise`
`33`	`38`	`(New-Object System.Net.WebClient).DownloadFile($compilerDownloadLink, $metaEditorPath)`
`34`	`39`	`}`
`35`	`40`	`}`