Skip to content
This repository was archived by the owner on Dec 12, 2018. It is now read-only.

Commit 74dbf11

Browse files
committed
Updated ExternalAccountStoreModelFactory to use the visitor adapter to get rid of empty methods from the interface.
1 parent 6e975b4 commit 74dbf11

File tree

1 file changed

+2
-14
lines changed

1 file changed

+2
-14
lines changed

extensions/servlet/src/main/java/com/stormpath/sdk/servlet/mvc/provider/ExternalAccountStoreModelFactory.java

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,8 @@
2323
import com.stormpath.sdk.application.webconfig.ApplicationWebConfig;
2424
import com.stormpath.sdk.application.webconfig.ApplicationWebConfigStatus;
2525
import com.stormpath.sdk.directory.AccountStore;
26-
import com.stormpath.sdk.directory.AccountStoreVisitor;
26+
import com.stormpath.sdk.directory.AccountStoreVisitorAdapter;
2727
import com.stormpath.sdk.directory.Directory;
28-
import com.stormpath.sdk.group.Group;
29-
import com.stormpath.sdk.organization.Organization;
3028
import com.stormpath.sdk.provider.GoogleProvider;
3129
import com.stormpath.sdk.provider.OAuthProvider;
3230
import com.stormpath.sdk.provider.Provider;
@@ -80,7 +78,7 @@ protected String getAuthorizeBaseUri(@SuppressWarnings("UnusedParameters") HttpS
8078
return authorizeBaseUri;
8179
}
8280

83-
private class AccountStoreModelVisitor implements AccountStoreVisitor {
81+
private class AccountStoreModelVisitor extends AccountStoreVisitorAdapter {
8482

8583
private final List<AccountStoreModel> accountStores;
8684
private final String authorizeBaseUri;
@@ -90,11 +88,6 @@ public AccountStoreModelVisitor(List<AccountStoreModel> accountStores, String au
9088
this.authorizeBaseUri = authorizeBaseUri;
9189
}
9290

93-
@Override
94-
public void visit(Group group) {
95-
//Do nothing... groups cannot be external
96-
}
97-
9891
//Only directories can support provider-based workflows:
9992
@Override
10093
public void visit(Directory directory) {
@@ -118,11 +111,6 @@ public void visit(Directory directory) {
118111
}
119112
}
120113

121-
@Override
122-
public void visit(Organization organization) {
123-
//Do nothing... organizations cannot be external
124-
}
125-
126114
public List<AccountStoreModel> getAccountStores() {
127115
return accountStores;
128116
}

0 commit comments

Comments
 (0)