fix: compat with virtual scroll containers (#181)

Author: marbemac

src/__stories__/JsonSchemaViewer.tsx

@@ -140,7 +140,8 @@ storiesOf('JsonSchemaViewer', module)
         </Box>
       </InvertTheme>
     );
-  });
+  })
+  .add('maxHeight', () => <JsonSchemaViewer schema={schema as JSONSchema4} maxHeight={number('maxHeight', 500)} />);
 
 storiesOf('JsonSchemaViewer/combiners', module)
   .addDecorator(withKnobs)

src/__stories__/_styles.scss

@@ -2,8 +2,7 @@
 @import '~@stoplight/mosaic/themes/default.css';
 
 .JsonSchemaViewer {
-  margin: auto;
+  margin: 20px auto;
   width: 100%;
-  padding: 20px;
   max-width: 800px;
 }

src/hooks/useIsOnScreen.ts

@@ -34,7 +34,7 @@ function getScrollParent(node: HTMLElement | null): HTMLElement | typeof window
     return null;
   }
 
-  if (node.scrollHeight > node.clientHeight) {
+  if (node.scrollHeight > node.clientHeight && node.clientHeight > 0) {
     return node.tagName === 'HTML' ? window : node;
   } else {
     return getScrollParent(node.parentElement);