-
Notifications
You must be signed in to change notification settings - Fork 117
https://issues.redhat.com/browse/ACM-23917 MCOA #8364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.15_stage
Are you sure you want to change the base?
Conversation
Removed unnecessary line breaks in API descriptions for clarity.
Removed outdated sections and streamlined content.
Added documentation for relabeling default metrics in the multicluster observability add-on, including prerequisites and steps.
Document the process for exporting metrics to external endpoints using PrometheusAgent.
Updated documentation to clarify the use of cluster ID for managed clusters and added health status information for the multicluster observability add-on.
Removed duplicate mention of `RightSizingRecommendation` in observability section.
|
|
||
| . Configure the `PrometheusRule` resource to limit the cardinality of your collected metrics on your hub cluster. Complete the following steps: | ||
|
|
||
| .. Define alerting and recording rules for custom workloads on your managed clusters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They can be defined for both platform and uwl monitoring.
As stated in my document:
For Prometheus rules targeting user-workloads, you must include the specific annotation observability.open-cluster-management.io/target-namespace to designate the namespace where the rule should be deployed.
Failure to include this annotation will result in the rules being deployed to the default installation namespace. This default namespace contains the openshift.io/cluster-monitoring=true label, which means the rules will not be monitored by the in-cluster user-workload monitoring stack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added within the notes. Let me know what you think
| . Configure the `PrometheusRule` resource to limit the cardinality of your collected metrics on your hub cluster. Complete the following steps: | ||
|
|
||
| .. Define alerting and recording rules for custom workloads on your managed clusters. | ||
| .. To define the namespace where you want to deploy your `PrometheusRule` resource, add the following annotation: `observability.open-cluster-management.io/target-namespace`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should explain why I think, as described in my above comment.
Co-authored-by: Oliver Fischer <108426932+oafischer@users.noreply.github.com>
Co-authored-by: Oliver Fischer <108426932+oafischer@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dockerymick, oafischer The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
release_notes/acm_new.adoc
Outdated
|
|
||
| - Use `RightSizingRecommendation` to optimize workloads and understand resource usage across your virtual machines. To learn more, see link:../observability/obs_right_size_intro.adoc#right-size-intro[`RightSizingRecommendation` guides (Technology Preview)]. | ||
| - Enable the multicluster observability add-on to collect platform metrics and user workloads from your managed clusters. For more information, see link:../observability/obs_mcoa_intro.adoc#obs-mcoa-intro[Multicluster observability add-on]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sounds like it was not possible to collect these metrics before. It definitely was.
MCOA introduces a new method of metrics collection, but we collect (more or less) the same metrics as before. Just using different set of technologies.
Co-authored-by: Jacob Baungård Hansen <jacobbaungard@redhat.com>
|
New changes are detected. LGTM label has been removed. |
|
@jacobbaungard @thibaultmg thank you both for your patience and willingness to collab. Please re-review when you have a chance |
Co-authored-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
No description provided.