feat(spi): remove skip receive from SPISettings

This parameter should not be part of SPISettings.

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>

Author: fpistm

libraries/SPI/README.md

@@ -7,10 +7,6 @@ User have 2 possibilities about the management of the CS pin:
 * the CS pin is managed directly by the user code before to transfer the data (like the Arduino SPI library)
 * the user uses a hardware CS pin linked to the SPI peripheral
 
-### New SPISetting parameter
-
-* `noReceive`: value can be `SPI_TRANSMITRECEIVE` or `SPI_TRANSMITONLY`. It allows to skip receive data after transmitting. Default `SPI_TRANSMITRECEIVE`.
-
 ### New API functions
 
 * `SPIClass::SPIClass(uint8_t mosi, uint8_t miso, uint8_t sclk, uint8_t ssel)`: alternative class constructor

libraries/SPI/src/SPI.cpp

@@ -160,7 +160,7 @@ void SPIClass::setClockDivider(uint8_t divider)
   */
 uint8_t SPIClass::transfer(uint8_t data)
 {
-  spi_transfer(&_spi, &data, sizeof(uint8_t), SPI_TRANSFER_TIMEOUT, _spiSettings.noReceive);
+  spi_transfer(&_spi, &data, sizeof(uint8_t), SPI_TRANSFER_TIMEOUT, false);
   return data;
 }
 
@@ -179,7 +179,7 @@ uint16_t SPIClass::transfer16(uint16_t data)
     data = tmp;
   }
   spi_transfer(&_spi, (uint8_t *)&data, sizeof(uint16_t),
-               SPI_TRANSFER_TIMEOUT, _spiSettings.noReceive);
+               SPI_TRANSFER_TIMEOUT, false);
 
   if (_spiSettings.bitOrder) {
     tmp = ((data & 0xff00) >> 8) | ((data & 0xff) << 8);
@@ -200,7 +200,7 @@ void SPIClass::transfer(void *buf, size_t count)
 {
   if ((count != 0) && (buf != NULL)) {
     spi_transfer(&_spi, ((uint8_t *)buf), count,
-                 SPI_TRANSFER_TIMEOUT, _spiSettings.noReceive);
+                 SPI_TRANSFER_TIMEOUT, false);
   }
 }
 

libraries/SPI/src/SPI.h

@@ -38,35 +38,29 @@ extern "C" {
 #define SPI_CLOCK_DIV64  64
 #define SPI_CLOCK_DIV128 128
 
-#define SPI_TRANSMITRECEIVE 0x0
-#define SPI_TRANSMITONLY 0x1
-
 // Defines a default timeout delay in milliseconds for the SPI transfer
 #ifndef SPI_TRANSFER_TIMEOUT
   #define SPI_TRANSFER_TIMEOUT 1000
 #endif
 
 class SPISettings {
   public:
-    constexpr SPISettings(uint32_t clock, BitOrder bitOrder, SPIMode dataMode, bool noRecv = SPI_TRANSMITRECEIVE)
+    constexpr SPISettings(uint32_t clock, BitOrder bitOrder, SPIMode dataMode)
       : clockFreq(clock),
         bitOrder(bitOrder),
-        dataMode(dataMode),
-        noReceive(noRecv)
+        dataMode(dataMode)
     { }
     constexpr SPISettings()
       : clockFreq(SPI_SPEED_CLOCK_DEFAULT),
         bitOrder(MSBFIRST),
-        dataMode(SPI_MODE0),
-        noReceive(SPI_TRANSMITRECEIVE)
+        dataMode(SPI_MODE0)
     { }
 
     bool operator==(const SPISettings &rhs) const
     {
       if ((this->clockFreq == rhs.clockFreq) &&
           (this->bitOrder == rhs.bitOrder) &&
-          (this->dataMode == rhs.dataMode) &&
-          (this->noReceive == rhs.noReceive)) {
+          (this->dataMode == rhs.dataMode)) {
         return true;
       }
       return false;
@@ -81,7 +75,6 @@ class SPISettings {
     uint32_t clockFreq; //specifies the spi bus maximum clock speed
     BitOrder bitOrder;  //bit order (MSBFirst or LSBFirst)
     SPIMode  dataMode;  //one of the data mode
-    bool noReceive;
 
     friend class SPIClass;
 };