Add digitalPinIsValid() function

fpistm · fpistm · commit 8011329a9f1d · 2017-07-10T19:05:11.000+02:00
Handle if pin is valid (!=NC)
Used for firmata.

Signed-off-by: Frederic.Pillon &lt;frederic.pillon@st.com&gt;
diff --git a/cores/arduino/pins_arduino.h b/cores/arduino/pins_arduino.h
@@ -65,6 +65,8 @@ uint32_t pinNametoDigitalPin(PinName p);
 #define digitalPinToPort(p)        ( get_GPIO_Port(digitalPinToPinName(p)) )
 #define digitalPinToBitMask(p)     ( STM_GPIO_PIN(digitalPinToPinName(p)) )
 
+#define digitalPinIsValid(p)       (digitalPinToPinName(p) != NC)
+
 #ifdef __cplusplus
 }
 #endif
diff --git a/libraries/Firmata/Boards.h b/libraries/Firmata/Boards.h
@@ -771,7 +771,7 @@ writePort(port, value, bitmask):  Write an 8 bit port.
 #define TOTAL_PORTS             MAX_NB_PORT
 #define VERSION_BLINK_PIN       LED_BUILTIN
 // PIN_SERIALY_RX/TX defined in the variant.h
-#define IS_PIN_DIGITAL(p)       ((p != PIN_SERIAL_RX) && (p != PIN_SERIAL_TX) && (p < TOTAL_PINS))
+#define IS_PIN_DIGITAL(p)       (digitalPinIsValid(p) && (p != PIN_SERIAL_RX) && (p != PIN_SERIAL_TX))
 #define IS_PIN_ANALOG(p)        ((p) >= A0 && (p) < AEND)
 #define IS_PIN_PWM(p)           digitalPinHasPWM(p)
 #define IS_PIN_SERVO(p)         IS_PIN_DIGITAL(p)

Original file line number	Diff line number	Diff line change
`@@ -65,6 +65,8 @@ uint32_t pinNametoDigitalPin(PinName p);`
`65`	`65`	`#define digitalPinToPort(p) ( get_GPIO_Port(digitalPinToPinName(p)) )`
`66`	`66`	`#define digitalPinToBitMask(p) ( STM_GPIO_PIN(digitalPinToPinName(p)) )`
`67`	`67`
	`68`	`+#define digitalPinIsValid(p) (digitalPinToPinName(p) != NC)`
	`69`	`+`
`68`	`70`	`#ifdef __cplusplus`
`69`	`71`	`}`
`70`	`72`	`#endif`