CI (#92)

* Ci2 (#6)

* Add g491 and 4a1 to ci, check examples, check with different feature sets

* Add todo

* Remove unused feature embedded-can-03

* Remove feature unstable-defmt from ci

* Add clippy to ci

* Fix warning

* g91 and 4a1 support does not seem quite ready yet

* Fix CI errors for flash example

* Deny warnings

* Fix more warnings

* Fix warnings about empty loops

* Fix more warnings related to itm or semihosting

* Make itm use log::info as println to avoid logger arg

* CI - Always enable some way to print

Author: usbalbin

.github/workflows/ci.yml

@@ -3,21 +3,32 @@ on:
 
 name: Continuous integration
 
+# Make sure CI fails on all warnings, including Clippy lints
+env:
+  RUSTFLAGS: "-Dwarnings"
+
 jobs:
   ci:
     runs-on: ubuntu-latest
     strategy:
       matrix:
         rust:
           - stable
-        feature:
+        device:
           - stm32g431
           - stm32g441
           - stm32g471
           - stm32g473
           - stm32g474
           - stm32g483
           - stm32g484
+          #- stm32g491 # Does not seem ready yet
+          #- stm32g4a1 # Does not seem ready yet
+        features:
+          - log-rtt,defmt
+          # TODO: -log-rtt # log-rtt without defmt, more combos?
+          - log-itm
+          - log-semihost
 
     steps:
       - uses: actions/checkout@v2
@@ -29,4 +40,8 @@ jobs:
           override: true
 
       - name: Regular build
-        run: cargo check --features ${{ matrix.feature }}
+        run: cargo check --features ${{ matrix.device }} --features ${{ matrix.features }}
+      - name: Build examples
+        run: cargo check --examples --features ${{ matrix.device }} --features ${{ matrix.features }}
+      - name: Clippy
+        run: cargo clippy --examples --features ${{ matrix.device }} --features ${{ matrix.features }}

.github/workflows/clippy.yml

@@ -19,4 +19,4 @@ jobs:
       - uses: actions-rs/clippy-check@v1
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
-          args: --features=stm32g431 --target thumbv7em-none-eabihf
+          args: --features=stm32g484,log-rtt,defmt --target thumbv7em-none-eabihf

Cargo.toml

@@ -104,4 +104,4 @@ lto = true
 
 [[example]]
 name = "flash_with_rtic"
-required-features = ["stm32g474"]
+required-features = ["stm32g474"]

examples/button.rs

@@ -50,6 +50,8 @@ fn EXTI15_10() {
 
 #[entry]
 fn main() -> ! {
+    utils::logger::init();
+
     let mut dp = stm32::Peripherals::take().expect("cannot take peripherals");
     let mut rcc = dp.RCC.constrain();
     let mut syscfg = dp.SYSCFG.constrain();

examples/comp.rs

@@ -16,6 +16,7 @@ use rt::entry;
 #[cfg(not(feature = "stm32g474"))]
 #[entry]
 fn main() -> ! {
+    #[allow(clippy::empty_loop)]
     loop {} // TODO: add support for more devices
 }
 

examples/comp_w_dac.rs

@@ -11,6 +11,7 @@ use rt::entry;
 #[cfg(not(feature = "stm32g474"))]
 #[entry]
 fn main() -> ! {
+    #[allow(clippy::empty_loop)]
     loop {} // TODO: add support for more devices
 }
 

examples/flash_with_rtic.rs

@@ -38,6 +38,8 @@ mod app {
 
     #[init]
     fn init(cx: init::Context) -> (Shared, Local, init::Monotonics) {
+        crate::utils::logger::init();
+
         let dp = cx.device;
         let cp = cx.core;
 

examples/hello.rs

@@ -16,6 +16,8 @@ use utils::logger::println;
 
 #[entry]
 fn main() -> ! {
+    utils::logger::init();
+
     println!("Hello, STM32G4!");
 
     #[allow(clippy::empty_loop)]

examples/independent_watchdog.rs

@@ -12,7 +12,7 @@ use utils::logger::info;
 
 #[entry]
 fn main() -> ! {
-    //utils::logger::init();
+    utils::logger::init();
     let dp = Peripherals::take().unwrap();
 
     let mut watchdog = IndependentWatchdog::new(dp.IWDG);

examples/panic.rs

@@ -22,6 +22,8 @@ pub fn exit() -> ! {
 
 #[cortex_m_rt::entry]
 fn main() -> ! {
+    utils::logger::init();
+
     logger::info!("main");
 
     panic!("Something bad");