Add some more status bit checks and pretty defmt print for Mac

Author: datdenkikniet

src/mac/frame_filtering/mod.rs

@@ -90,7 +90,7 @@ pub struct FrameFiltering {
 impl FrameFiltering {
     /// Create a new basic [`FrameFiltering`] that:
     /// * Does not filter out frames destined for `station_addr` or an address
-    /// contained in `extra_address.
+    /// contained in `extra_address`.
     /// * Does not filter out multicast frames.
     /// * Does not filter out broadcast frames.
     /// * Filters out all control frames.
@@ -244,6 +244,25 @@ impl Mac {
         Self(address)
     }
 
+    /// Get the raw bytes of this MAC address.
+    pub fn raw(&self) -> &[u8; 6] {
+        &self.0
+    }
+    /// Returns `true` if this MAC is locally administred, i.e. it has the I/G bit set.
+    pub fn is_multicast(&self) -> bool {
+        (self.0[0] & 0b1) == 0b1
+    }
+
+    /// Returns `true` if this MAC is locally administred, i.e. it has the U/L bit set.
+    pub fn is_locally_administred(&self) -> bool {
+        (self.0[0] & 0b10) == 0b10
+    }
+
+    /// Returns `true` if this MAC is the broadcast address.
+    pub fn is_broadcast(&self) -> bool {
+        self.0.iter().all(|v| v == &0xFF)
+    }
+
     /// Return bytes in a form that can be put into the high portion
     /// of a MAC address register by converting them to little-endian
     fn high(&self) -> u16 {
@@ -265,6 +284,23 @@ impl From<[u8; 6]> for Mac {
     }
 }
 
+#[cfg(feature = "defmt")]
+impl defmt::Format for Mac {
+    fn format(&self, fmt: defmt::Formatter) {
+        let addr = self.0;
+        defmt::write!(
+            fmt,
+            "{:02X}:{:02X}:{:02X}:{:02X}:{:02X}:{:02X}",
+            addr[0],
+            addr[1],
+            addr[2],
+            addr[3],
+            addr[4],
+            addr[5]
+        )
+    }
+}
+
 /// A MAC address filter
 #[derive(Debug, Clone)]
 

src/rx.rs

@@ -34,6 +34,8 @@ const RXDESC_0_ES: u32 = 1 << 15;
 const RXDESC_0_FL_MASK: u32 = 0x3FFF;
 const RXDESC_0_FL_SHIFT: usize = 16;
 
+const RXDESC_0_SAF: u32 = 1 << 13;
+
 const RXDESC_1_RBS_SHIFT: usize = 0;
 const RXDESC_1_RBS_MASK: u32 = 0x0fff << RXDESC_1_RBS_SHIFT;
 /// Second address chained
@@ -123,6 +125,10 @@ impl RxDescriptor {
     fn get_frame_len(&self) -> usize {
         ((self.desc.read(0) >> RXDESC_0_FL_SHIFT) & RXDESC_0_FL_MASK) as usize
     }
+
+    fn failed_saf(&self) -> bool {
+        (self.desc.read(0) & RXDESC_0_SAF) == RXDESC_0_SAF
+    }
 }
 
 /// An RX DMA Ring Descriptor entry
@@ -203,6 +209,11 @@ impl<'a> RxPacket<'a> {
     pub fn free(self) {
         drop(self)
     }
+
+    // Whether or not the packet failed the source address filter.
+    pub fn failed_source_address_filter(&self) -> bool {
+        self.entry.desc().failed_saf()
+    }
 }
 
 /// Rx DMA state