Make all running state public, and use "stateless" access

Author: datdenkikniet

src/dma/mod.rs

@@ -402,12 +402,12 @@ impl<'rx, 'tx> EthernetDMA<'rx, 'tx> {
     /// It stops if the ring is full. Call [`EthernetDMA::recv_next()`] to free an
     /// entry and to demand poll from the hardware.
     pub fn rx_is_running(&self) -> bool {
-        self.rx_ring.running_state().is_running()
+        RxRing::running_state().is_running()
     }
 
     /// Is Tx DMA currently running?
     pub fn tx_is_running(&self) -> bool {
-        self.tx_ring.is_running()
+        TxRing::is_running()
     }
 
     /// Try to send a packet with data.

src/dma/rx/mod.rs

@@ -149,7 +149,7 @@ impl<'a> RxRing<'a> {
         // DMA accesses do not stop before the running state
         // of the DMA has changed to something other than
         // running.
-        while self.running_state().is_running() {}
+        while Self::running_state().is_running() {}
     }
 
     /// Demand that the DMA engine polls the current `RxDescriptor`
@@ -176,8 +176,8 @@ impl<'a> RxRing<'a> {
             .modify(|r, w| unsafe { w.bits(r.bits()) });
     }
 
-    /// Get current `RunningState`
-    pub fn running_state(&self) -> RunningState {
+    /// Get current state of the RxDMA
+    pub fn running_state() -> RunningState {
         // SAFETY: we only perform an atomic read of `dmasr`.
         let eth_dma = unsafe { &*ETHERNET_DMA::ptr() };
 
@@ -229,7 +229,7 @@ impl<'a> RxRing<'a> {
         // NOTE(allow): packet_id is unused if ptp is disabled.
         #[allow(unused_variables)] packet_id: Option<PacketId>,
     ) -> Result<usize, RxError> {
-        if !self.running_state().is_running() {
+        if !Self::running_state().is_running() {
             Self::demand_poll();
         }
 

src/dma/tx/mod.rs

@@ -121,7 +121,7 @@ impl<'ring> TxRing<'ring> {
         // DMA accesses do not stop before the running state
         // of the DMA has changed to something other than
         // running.
-        while self.is_running() {}
+        while Self::is_running() {}
     }
 
     fn entry_available(&self, index: usize) -> bool {
@@ -248,11 +248,12 @@ impl<'ring> TxRing<'ring> {
     }
 
     /// Is the Tx DMA engine running?
-    pub fn is_running(&self) -> bool {
-        self.running_state().is_running()
+    pub fn is_running() -> bool {
+        Self::running_state().is_running()
     }
 
-    pub(crate) fn running_state(&self) -> RunningState {
+    /// Get the current state of the TxDMA
+    pub fn running_state() -> RunningState {
         // SAFETY: we only perform an atomic read of `dmasr` or
         // `dmadsr`.
         let eth_dma = unsafe { &*ETHERNET_DMA::ptr() };