Move const to HashConfig

Author: stfndamjanovic

src/Charset.php

@@ -6,6 +6,10 @@
 
 class HashConfig
 {
+    const CHARSET_UPPERCASE = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
+    const CHARSET_LOWERCASE = "abcdefghijklmnopqrstuvwxyz";
+    const CHARSET_NUMERIC = "0123456789";
+
     protected $length;
 
     protected $count = 1;
@@ -23,7 +27,7 @@ class HashConfig
     public function __construct($length = 16)
     {
         $this->length = $length;
-        $this->charset = Charset::LOWERCASE->value . Charset::UPPERCASE->value . Charset::NUMERIC->value;
+        $this->charset = self::CHARSET_LOWERCASE . self::CHARSET_UPPERCASE . self::CHARSET_NUMERIC;
     }
 
     public static function make($length = 16)
@@ -70,21 +74,21 @@ public function charset(string $charset): self
 
     public function upperCaseOnly(): self
     {
-        $this->charset = Charset::UPPERCASE->value;
+        $this->charset = self::CHARSET_UPPERCASE;
 
         return $this;
     }
 
     public function lowerCaseOnly(): self
     {
-        $this->charset = Charset::LOWERCASE->value;
+        $this->charset = self::CHARSET_LOWERCASE;
 
         return $this;
     }
 
     public function numbersOnly(): self
     {
-        $this->charset = Charset::NUMERIC->value;
+        $this->charset = self::CHARSET_NUMERIC;
 
         return $this;
     }

src/HashConfig.php

@@ -3,7 +3,6 @@
 namespace Stfn\RandomHash\Tests;
 
 use PHPUnit\Framework\TestCase;
-use Stfn\RandomHash\Charset;
 use Stfn\RandomHash\InvalidConfigException;
 use Stfn\RandomHash\RandomHash;
 use Stfn\RandomHash\HashConfig;
@@ -124,7 +123,7 @@ public function test_if_it_can_generate_alphanumeric()
     {
         $config = new HashConfig();
         $config->length(10)
-            ->charset(Charset::UPPERCASE->value . Charset::LOWERCASE->value . Charset::NUMERIC->value);
+            ->charset(HashConfig::CHARSET_UPPERCASE . HashConfig::CHARSET_LOWERCASE . HashConfig::CHARSET_NUMERIC);
 
         $instance = new RandomHash($config);
         $hash = $instance->generate();