Skip to content

Conversation

@saipramod
Copy link

@saipramod saipramod commented Dec 10, 2022

ability to do git add -f <file1> <file2>

@changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2022

⚠️ No Changeset found

Latest commit: 0b68d9a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@saipramod saipramod changed the title include the --force of git add by default. include the --force when performing git add by default. Dec 10, 2022
@saipramod saipramod changed the title include the --force when performing git add by default. option to include the --force when performing git add by default. Dec 10, 2022
@saipramod saipramod marked this pull request as ready for review December 10, 2022 19:55
* Adds one or more files to source control
*/
add(files: string | string[], callback?: types.SimpleGitTaskCallback<string>): Response<string>;
add(files: string | string[], force: bool = false, callback?: types.SimpleGitTaskCallback<string>): Response<string>;
Copy link

@widoz widoz Jul 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a breaking change, why not introducing an optional options after the callback instead?
Also, is the default value allowed in this context?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants