Skip to content

Commit 9e2d1a6

Browse files
committed
Changed event bind test to inlcude cursor position for mouse events
This is a safety measure to make sure that we don't send undefined pageX and pageY coordinates into the system. Partially related to issue #147. Because tests started failing when I was modifying the isMouseEvent() utility function.
1 parent 64ad28e commit 9e2d1a6

File tree

1 file changed

+16
-8
lines changed

1 file changed

+16
-8
lines changed

test/unit/core.js

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,19 @@ $(function() {
5959
});
6060

6161
QUnit.test('powerTip hooks events', function(assert) {
62-
var openEvents = [ 'mouseenter', 'focus', 'customOpenEvent' ],
63-
closeEvents = [ 'mouseleave', 'blur', 'customCloseEvent' ],
62+
var openEvents = {
63+
mouseenter: { pageX: 14, pageY: 14 },
64+
focus: null,
65+
customOpenEvent: null
66+
},
67+
closeEvents = {
68+
mouseleave: { pageX: 14, pageY: 14 },
69+
blur: null,
70+
customCloseEvent: null
71+
},
6472
element = $('<a href="#" title="This is the tooltip text">TEXT</a>').powerTip({
65-
openEvents: openEvents,
66-
closeEvents: closeEvents
73+
openEvents: Object.keys(openEvents),
74+
closeEvents: Object.keys(closeEvents)
6775
}),
6876
showTriggered = false,
6977
hideTriggered = false;
@@ -86,16 +94,16 @@ $(function() {
8694
$('body').prepend(element);
8795

8896
// test open events
89-
$.each(openEvents, function(idx, eventName) {
97+
$.each(openEvents, function(eventName, eventData) {
9098
showTriggered = false;
91-
element.triggerHandler(eventName);
99+
element.triggerHandler(new $.Event(eventName, eventData));
92100
assert.strictEqual(showTriggered, true, eventName + ' event calls DisplayController.show');
93101
});
94102

95103
// test close events
96-
$.each(closeEvents, function(idx, eventName) {
104+
$.each(closeEvents, function(eventName, eventData) {
97105
hideTriggered = false;
98-
element.triggerHandler(eventName);
106+
element.triggerHandler(new $.Event(eventName, eventData));
99107
assert.strictEqual(hideTriggered, true, eventName + ' event calls DisplayController.hide');
100108
});
101109

0 commit comments

Comments
 (0)