Add a release checklist

Author: jberkel

.cocoadocs.yml

@@ -0,0 +1,10 @@
+# SQLite.swift Release checklist
+
+* [ ] Make sure current master branch has a green build
+* [ ] Make sure `CHANGELOG.md` is up-to-date
+* [ ] Run `pod lib lint` locally
+* [ ] Update the version numbers mentioned in `README.md`, `Documentation/Index.md`
+* [ ] Update `MARKETING_VERSION` in `SQLite.xcodeproj/project.pbxproj`
+* [ ] Create a tag with the version number (`x.y.z`)
+* [ ] Publish to CocoaPods: `pod trunk push`
+* [ ] Update the release information on GitHub

Documentation/Release.md

@@ -232,6 +232,7 @@
 		19A17BA55DABB480F9020C8A /* DateAndTimeFunctions.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = DateAndTimeFunctions.swift; sourceTree = "<group>"; };
 		19A17E2695737FAB5D6086E3 /* fixtures */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = folder; path = fixtures; sourceTree = "<group>"; };
 		3717F907221F5D7C00B9BD3D /* CustomAggregationTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CustomAggregationTests.swift; sourceTree = "<group>"; };
+		19A17EA3A313F129011B3FA0 /* Release.md */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = net.daringfireball.markdown; path = Release.md; sourceTree = "<group>"; };
 		3D67B3E51DB2469200A4F4C6 /* libsqlite3.tbd */ = {isa = PBXFileReference; lastKnownFileType = "sourcecode.text-based-dylib-definition"; name = libsqlite3.tbd; path = Platforms/WatchOS.platform/Developer/SDKs/WatchOS3.0.sdk/usr/lib/libsqlite3.tbd; sourceTree = DEVELOPER_DIR; };
 		3DDC112E26CDBA0200CE369F /* SQLiteObjc.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = SQLiteObjc.h; path = ../SQLiteObjc/include/SQLiteObjc.h; sourceTree = "<group>"; };
 		49EB68C31F7B3CB400D89D40 /* Coding.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Coding.swift; sourceTree = "<group>"; };
@@ -496,6 +497,7 @@
 			children = (
 				EE247B8F1C3F822500AE3E12 /* Index.md */,
 				EE247B901C3F822500AE3E12 /* Resources */,
+				19A17EA3A313F129011B3FA0 /* Release.md */,
 			);
 			path = Documentation;
 			sourceTree = "<group>";

SQLite.xcodeproj/project.pbxproj

@@ -160,67 +160,67 @@ public extension Connection {
     }
 
     // MARK: -
-    
-    public func createAggregation<T: AnyObject>(
+
+    func createAggregation<T: AnyObject>(
         _ aggregate: String,
         argumentCount: UInt? = nil,
         deterministic: Bool = false,
         initialValue: T,
         reduce: @escaping (T, [Binding?]) -> T,
         result: @escaping (T) -> Binding?
         ) {
-        
+
         let step: ([Binding?], UnsafeMutablePointer<UnsafeMutableRawPointer>) -> () = { (bindings, ptr) in
             let p = ptr.pointee.assumingMemoryBound(to: T.self)
             let current = Unmanaged<T>.fromOpaque(p).takeRetainedValue()
             let next = reduce(current, bindings)
             ptr.pointee = Unmanaged.passRetained(next).toOpaque()
         }
-        
+
         let final: (UnsafeMutablePointer<UnsafeMutableRawPointer>) -> Binding? = { (ptr) in
             let p = ptr.pointee.assumingMemoryBound(to: T.self)
             let obj = Unmanaged<T>.fromOpaque(p).takeRetainedValue()
             let value = result(obj)
             ptr.deallocate()
             return value
         }
-        
+
         let state: () -> UnsafeMutablePointer<UnsafeMutableRawPointer> = {
             let p = UnsafeMutablePointer<UnsafeMutableRawPointer>.allocate(capacity: 1)
             p.pointee = Unmanaged.passRetained(initialValue).toOpaque()
             return p
         }
-        
+
         createAggregation(aggregate, step: step, final: final, state: state)
     }
-    
-    public func createAggregation<T>(
+
+    func createAggregation<T>(
         _ aggregate: String,
         argumentCount: UInt? = nil,
         deterministic: Bool = false,
         initialValue: T,
         reduce: @escaping (T, [Binding?]) -> T,
         result: @escaping (T) -> Binding?
         ) {
-        
+
         let step: ([Binding?], UnsafeMutablePointer<T>) -> () = { (bindings, p) in
             let current = p.pointee
             let next = reduce(current, bindings)
             p.pointee = next
         }
-        
+
         let final: (UnsafeMutablePointer<T>) -> Binding? = { (p) in
             let v = result(p.pointee)
             p.deallocate()
             return v
         }
-        
+
         let state: () -> UnsafeMutablePointer<T> = {
             let p = UnsafeMutablePointer<T>.allocate(capacity: 1)
             p.pointee = initialValue
             return p
         }
-        
+
         createAggregation(aggregate, step: step, final: final, state: state)
     }
 

Sources/SQLite/Typed/CustomFunctions.swift

@@ -16,19 +16,19 @@ import SQLite3
 class CustomAggregationTests : SQLiteTestCase {
     override func setUp() {
         super.setUp()
-        CreateUsersTable()
-        try! InsertUser("Alice", age: 30, admin: true)
-        try! InsertUser("Bob", age: 25, admin: true)
-        try! InsertUser("Eve", age: 28, admin: false)
+        createUsersTable()
+        try! insertUser("Alice", age: 30, admin: true)
+        try! insertUser("Bob", age: 25, admin: true)
+        try! insertUser("Eve", age: 28, admin: false)
     }
-    
+
     func testUnsafeCustomSum() {
         let step = { (bindings: [Binding?], state: UnsafeMutablePointer<Int64>) in
             if let v = bindings[0] as? Int64 {
                 state.pointee += v
             }
         }
-        
+
         let final = { (state: UnsafeMutablePointer<Int64>) -> Binding? in
             let v = state.pointee
             let p = UnsafeMutableBufferPointer(start: state, count: 1)
@@ -41,13 +41,13 @@ class CustomAggregationTests : SQLiteTestCase {
             return v.baseAddress!
         }
         let result = try! db.prepare("SELECT mySUM1(age) AS s FROM users")
-        let i = result.columnNames.index(of: "s")!
+        let i = result.columnNames.firstIndex(of: "s")!
         for row in result {
             let value = row[i] as? Int64
             XCTAssertEqual(83, value)
         }
     }
-    
+
     func testUnsafeCustomSumGrouping() {
         let step = { (bindings: [Binding?], state: UnsafeMutablePointer<Int64>) in
             if let v = bindings[0] as? Int64 {
@@ -66,19 +66,19 @@ class CustomAggregationTests : SQLiteTestCase {
             return v.baseAddress!
         }
         let result = try! db.prepare("SELECT mySUM2(age) AS s FROM users GROUP BY admin ORDER BY s")
-        let i = result.columnNames.index(of: "s")!
+        let i = result.columnNames.firstIndex(of: "s")!
         let values = result.compactMap { $0[i] as? Int64 }
         XCTAssertTrue(values.elementsEqual([28, 55]))
     }
-    
+
     func testCustomSum() {
         let reduce : (Int64, [Binding?]) -> Int64 = { (last, bindings) in
             let v = (bindings[0] as? Int64) ?? 0
             return last + v
         }
         let _ = db.createAggregation("myReduceSUM1", initialValue: Int64(2000), reduce: reduce, result: { $0 })
         let result = try! db.prepare("SELECT myReduceSUM1(age) AS s FROM users")
-        let i = result.columnNames.index(of: "s")!
+        let i = result.columnNames.firstIndex(of: "s")!
         for row in result {
             let value = row[i] as? Int64
             XCTAssertEqual(2083, value)
@@ -92,11 +92,11 @@ class CustomAggregationTests : SQLiteTestCase {
         }
         let _ = db.createAggregation("myReduceSUM2", initialValue: Int64(3000), reduce: reduce, result: { $0 })
         let result = try! db.prepare("SELECT myReduceSUM2(age) AS s FROM users GROUP BY admin ORDER BY s")
-        let i = result.columnNames.index(of: "s")!
+        let i = result.columnNames.firstIndex(of: "s")!
         let values = result.compactMap { $0[i] as? Int64 }
         XCTAssertTrue(values.elementsEqual([3028, 3055]))
     }
-    
+
     func testCustomStringAgg() {
         let initial = String(repeating: " ", count: 64)
         let reduce : (String, [Binding?]) -> String = { (last, bindings) in
@@ -105,13 +105,13 @@ class CustomAggregationTests : SQLiteTestCase {
         }
         let _ = db.createAggregation("myReduceSUM3", initialValue: initial, reduce: reduce, result: { $0 })
         let result = try! db.prepare("SELECT myReduceSUM3(email) AS s FROM users")
-        let i = result.columnNames.index(of: "s")!
+        let i = result.columnNames.firstIndex(of: "s")!
         for row in result {
             let value = row[i] as? String
             XCTAssertEqual("\(initial)Alice@example.comBob@example.comEve@example.com", value)
         }
     }
-    
+
     func testCustomObjectSum() {
         {
             let initial = TestObject(value: 1000)
@@ -126,7 +126,7 @@ class CustomAggregationTests : SQLiteTestCase {
         {
             XCTAssertEqual(TestObject.inits, 1)
             let result = try! db.prepare("SELECT myReduceSUMX(age) AS s FROM users")
-            let i = result.columnNames.index(of: "s")!
+            let i = result.columnNames.firstIndex(of: "s")!
             for row in result {
                 let value = row[i] as? Int64
                 XCTAssertEqual(1083, value)
@@ -143,7 +143,7 @@ class CustomAggregationTests : SQLiteTestCase {
 class TestObject {
     static var inits = 0
     static var deinits = 0
-    
+
     var value: Int64
     init(value: Int64) {
         self.value = value