Should error after commit

[Dreamsorcerer]

Expected behaviour:
The CI should error and exit after a commit is made (in the typical usecase of auto-commiting fixes, e.g. from a linter).

Actual behaviour:
The CI continues to run and ends up passing.

I couldn't see any options that would configure this behaviour.

[stefanzweifel]

Thanks for the suggestion.

I personally don't see that this is as the expected behaviour. In your use case, you might run a linter and you might want the workflow to fail.
In my team or personal projects, we don't want this behaviour.

However, you can build this feature on your own by using the output of git-auto-commit.

Here's an example workflow (not tested) that checks the changes_detected output and fails the job/workflow, if the value is 'true'.

name: Check and Fail on Changes

on:
  push:
    branches:
      - main

jobs:
  check-changes:
    runs-on: ubuntu-latest

    steps:
      - name: Checkout code
        uses: actions/checkout@v4

      - name: Run php-cs-fixer or other formatting tool
        run: |
          # Replace this with your actual formatting command
          php-cs-fixer fix .

      - name: Auto-commit changes
        uses: stefanzweifel/git-auto-commit-action@v5
        id: auto-commit-action
        with:
          commit_message: Apply php-cs-fixer changes

      - name: Fail workflow if changes have been detected
        if: steps.auto-commit-action.outputs.changes_detected == 'true'
        run: |
          echo "Changes were detected and committed. Failing the workflow."
          exit 1

[Dreamsorcerer]

I personally don't see that this is as the expected behaviour

I think in the linter setup, this would typically be expected. If it commits changes, then that means the linter found violations. In a non-committing situation, the linter step would have failed by default.
Anyway, I wasn't expecting you to change the default behaviour. That solution looks like it'll work nicely, I didn't notice that option when looking through the examples.