Merge pull request #96 from gdraynz/replace-array-indexerror

Ensure an item is within the upper array boundaries before replacing it

Author: stefankoegl

jsonpatch.py

@@ -474,7 +474,7 @@ def apply(self, obj):
             return value
 
         if isinstance(subobj, MutableSequence):
-            if part > len(subobj) or part < 0:
+            if part >= len(subobj) or part < 0:
                 raise JsonPatchConflict("can't replace outside of list")
 
         elif isinstance(subobj, MutableMapping):

tests.py

@@ -611,6 +611,11 @@ def test_replace_oob(self):
         patch_obj = [ { "op": "replace", "path": "/foo/10", "value": 10} ]
         self.assertRaises(jsonpatch.JsonPatchConflict, jsonpatch.apply_patch, src, patch_obj)
 
+    def test_replace_oob_length(self):
+        src = {"foo": [0, 1]}
+        patch_obj = [ { "op": "replace", "path": "/foo/2", "value": 2} ]
+        self.assertRaises(jsonpatch.JsonPatchConflict, jsonpatch.apply_patch, src, patch_obj)
+
     def test_replace_missing(self):
         src = {"foo": 1}
         patch_obj = [ { "op": "replace", "path": "/bar", "value": 10} ]