From 7a2525d10dcba200088cabee0d1cb34cab58c54a Mon Sep 17 00:00:00 2001 From: JavaTypedScript Date: Tue, 2 Dec 2025 05:17:56 +0000 Subject: [PATCH 1/5] chore: fix JavaScript lint errors (issue #8701) --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../@stdlib/_tools/pkgs/entry-points/lib/resolve.js | 4 ++-- .../@stdlib/utils/key-by-right/benchmark/benchmark.js | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/node_modules/@stdlib/_tools/pkgs/entry-points/lib/resolve.js b/lib/node_modules/@stdlib/_tools/pkgs/entry-points/lib/resolve.js index 8e60d950de8e..d1412bded7c7 100644 --- a/lib/node_modules/@stdlib/_tools/pkgs/entry-points/lib/resolve.js +++ b/lib/node_modules/@stdlib/_tools/pkgs/entry-points/lib/resolve.js @@ -22,6 +22,7 @@ var logger = require( 'debug' ); var resolve = require( 'resolve' ); +var nulls = require( '@stdlib/array/base/nulls' ); var resolveDir = require( './resolve_dir.js' ); @@ -50,8 +51,7 @@ function getPkgs( pkgs, dir, clbk ) { len = pkgs.length; debug( 'Resolving %d packages...', len ); - - out = new Array( len ); + out = nulls( len ); count = 0; for ( i = 0; i < len; i++ ) { debug( 'Resolving package: %s (%d of %d).', pkgs[ i ], i+1, len ); diff --git a/lib/node_modules/@stdlib/utils/key-by-right/benchmark/benchmark.js b/lib/node_modules/@stdlib/utils/key-by-right/benchmark/benchmark.js index 2c1bcb9026a8..c9c98e7816b6 100644 --- a/lib/node_modules/@stdlib/utils/key-by-right/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/utils/key-by-right/benchmark/benchmark.js @@ -22,6 +22,7 @@ var bench = require( '@stdlib/bench' ); var randu = require( '@stdlib/random/base/randu' ); +var nulls = require( '@stdlib/array/base/nulls' ); var pkg = require( './../package.json' ).name; var keyByRight = require( './../lib' ); @@ -37,7 +38,7 @@ bench( pkg, function benchmark( b ) { return value.name; } - arr = new Array( 100 ); + arr = nulls( 100 ); for ( i = 0; i < arr.length; i++ ) { arr[ i ] = { 'name': 'v'+i, @@ -69,7 +70,7 @@ bench( pkg+'::this_context', function benchmark( b ) { return value.name; } - arr = new Array( 100 ); + arr = nulls( 100 ); for ( i = 0; i < arr.length; i++ ) { arr[ i ] = { 'name': 'v'+i, From 02f4e387ca66831d1abd3dc55e5ad6f3a724c49a Mon Sep 17 00:00:00 2001 From: Athan Date: Mon, 1 Dec 2025 21:54:59 -0800 Subject: [PATCH 2/5] refactor: avoid duplicate initialization Signed-off-by: Athan --- .../@stdlib/_tools/pkgs/entry-points/lib/resolve.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/node_modules/@stdlib/_tools/pkgs/entry-points/lib/resolve.js b/lib/node_modules/@stdlib/_tools/pkgs/entry-points/lib/resolve.js index d1412bded7c7..4da3a9cf034b 100644 --- a/lib/node_modules/@stdlib/_tools/pkgs/entry-points/lib/resolve.js +++ b/lib/node_modules/@stdlib/_tools/pkgs/entry-points/lib/resolve.js @@ -22,7 +22,6 @@ var logger = require( 'debug' ); var resolve = require( 'resolve' ); -var nulls = require( '@stdlib/array/base/nulls' ); var resolveDir = require( './resolve_dir.js' ); @@ -51,19 +50,20 @@ function getPkgs( pkgs, dir, clbk ) { len = pkgs.length; debug( 'Resolving %d packages...', len ); - out = nulls( len ); + + out = []; count = 0; for ( i = 0; i < len; i++ ) { debug( 'Resolving package: %s (%d of %d).', pkgs[ i ], i+1, len ); opts = { 'basedir': dir }; - out[ i ] = { + out.push({ 'id': null, 'pkg': pkgs[ i ], 'dir': null, 'data': null - }; + }); resolve( pkgs[ i ], opts, createClbk( i ) ); } /** From d88028ed5f53cd5f4c70ed25a823f86435e57eaf Mon Sep 17 00:00:00 2001 From: Athan Date: Mon, 1 Dec 2025 21:55:18 -0800 Subject: [PATCH 3/5] style: remove whitespace Signed-off-by: Athan --- lib/node_modules/@stdlib/_tools/pkgs/entry-points/lib/resolve.js | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/node_modules/@stdlib/_tools/pkgs/entry-points/lib/resolve.js b/lib/node_modules/@stdlib/_tools/pkgs/entry-points/lib/resolve.js index 4da3a9cf034b..2e41e2a91519 100644 --- a/lib/node_modules/@stdlib/_tools/pkgs/entry-points/lib/resolve.js +++ b/lib/node_modules/@stdlib/_tools/pkgs/entry-points/lib/resolve.js @@ -50,7 +50,6 @@ function getPkgs( pkgs, dir, clbk ) { len = pkgs.length; debug( 'Resolving %d packages...', len ); - out = []; count = 0; for ( i = 0; i < len; i++ ) { From 5588668f017ac47699f1d71cd4d0406036d7c554 Mon Sep 17 00:00:00 2001 From: Athan Date: Mon, 1 Dec 2025 23:27:35 -0800 Subject: [PATCH 4/5] refactor: avoid double initialization Signed-off-by: Athan --- .../utils/key-by-right/benchmark/benchmark.js | 22 +++++++++---------- 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/lib/node_modules/@stdlib/utils/key-by-right/benchmark/benchmark.js b/lib/node_modules/@stdlib/utils/key-by-right/benchmark/benchmark.js index c9c98e7816b6..8502cebf9ef4 100644 --- a/lib/node_modules/@stdlib/utils/key-by-right/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/utils/key-by-right/benchmark/benchmark.js @@ -21,8 +21,6 @@ // MODULES // var bench = require( '@stdlib/bench' ); -var randu = require( '@stdlib/random/base/randu' ); -var nulls = require( '@stdlib/array/base/nulls' ); var pkg = require( './../package.json' ).name; var keyByRight = require( './../lib' ); @@ -38,16 +36,16 @@ bench( pkg, function benchmark( b ) { return value.name; } - arr = nulls( 100 ); - for ( i = 0; i < arr.length; i++ ) { - arr[ i ] = { + arr = []; + for ( i = 0; i < 100; i++ ) { + arr.push({ 'name': 'v'+i, 'value': i - }; + }); } b.tic(); for ( i = 0; i < b.iterations; i++ ) { - arr[ 0 ].value = randu(); + arr[ 0 ].value += 1; out = keyByRight( arr, toKey ); if ( typeof out !== 'object' ) { b.fail( 'should return an object' ); @@ -70,16 +68,16 @@ bench( pkg+'::this_context', function benchmark( b ) { return value.name; } - arr = nulls( 100 ); - for ( i = 0; i < arr.length; i++ ) { - arr[ i ] = { + arr = []; + for ( i = 0; i < 100; i++ ) { + arr.push({ 'name': 'v'+i, 'value': i - }; + }); } b.tic(); for ( i = 0; i < b.iterations; i++ ) { - arr[ 0 ].value = randu(); + arr[ 0 ].value += 1; out = keyByRight( arr, toKey, {} ); if ( typeof out !== 'object' ) { b.fail( 'should return an object' ); From a2954a1c5141b3f80a39ffcf341677a4b637d1de Mon Sep 17 00:00:00 2001 From: Athan Date: Mon, 1 Dec 2025 23:28:54 -0800 Subject: [PATCH 5/5] style: add empty line Signed-off-by: Athan --- lib/node_modules/@stdlib/_tools/pkgs/entry-points/lib/resolve.js | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/node_modules/@stdlib/_tools/pkgs/entry-points/lib/resolve.js b/lib/node_modules/@stdlib/_tools/pkgs/entry-points/lib/resolve.js index 2e41e2a91519..803513d2f146 100644 --- a/lib/node_modules/@stdlib/_tools/pkgs/entry-points/lib/resolve.js +++ b/lib/node_modules/@stdlib/_tools/pkgs/entry-points/lib/resolve.js @@ -50,6 +50,7 @@ function getPkgs( pkgs, dir, clbk ) { len = pkgs.length; debug( 'Resolving %d packages...', len ); + out = []; count = 0; for ( i = 0; i < len; i++ ) {