Skip to content

Commit c69e50f

Browse files
committed
made some rebase related fixes
1 parent 3d1038c commit c69e50f

File tree

4 files changed

+6
-13
lines changed

4 files changed

+6
-13
lines changed

beacon_chain/gossip_processing/eth2_processor.nim

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -254,10 +254,6 @@ proc processSignedBeaconBlock*(
254254
let blobs =
255255
when typeof(signedBlock).kind >= ConsensusFork.Deneb and
256256
typeof(signedBlock).kind < ConsensusFork.Fulu:
257-
if self.blobQuarantine[].hasBlobs(signedBlock):
258-
Opt.some(self.blobQuarantine[].popBlobs(signedBlock.root, signedBlock))
259-
when typeof(signedBlock).kind >= ConsensusFork.Deneb and
260-
typeof(signedBlock).kind < ConsensusFork.Fulu::
261257
let bres =
262258
self.blobQuarantine[].popSidecars(signedBlock.root, signedBlock)
263259
if bres.isSome():

beacon_chain/nimbus_beacon_node.nim

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -478,8 +478,6 @@ proc initFullNode(
478478
maybeFinalized = maybeFinalized)
479479
elif consensusFork >= ConsensusFork.Deneb and
480480
consensusFork < ConsensusFork.Fulu:
481-
if not blobQuarantine[].hasBlobs(forkyBlck):
482-
when consensusFork >= ConsensusFork.Deneb:
483481
let bres = blobQuarantine[].popSidecars(forkyBlck.root, forkyBlck)
484482
if bres.isSome():
485483
await blockProcessor[].addBlock(MsgSource.gossip, signedBlock, bres,

beacon_chain/rpc/rest_config_api.nim

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -300,11 +300,10 @@ proc installConfigApiHandlers*(router: var RestRouter, node: BeaconNode) =
300300
Base10.toString(cfg.VALIDATOR_CUSTODY_REQUIREMENT.uint64),
301301
BALANCE_PER_ADDITIONAL_CUSTODY_GROUP:
302302
Base10.toString(cfg.BALANCE_PER_ADDITIONAL_CUSTODY_GROUP),
303-
# MAX_BLOBS_PER_BLOCK_FULU:
304-
# Base10.toString(cfg.MAX_BLOBS_PER_BLOCK_FULU),
305-
Base10.toString(BALANCE_PER_ADDITIONAL_CUSTODY_GROUP),
306-
# MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS:
307-
# Base10.toString(cfg.MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS),
303+
MAX_BLOBS_PER_BLOCK_FULU:
304+
Base10.toString(cfg.MAX_BLOBS_PER_BLOCK_FULU),
305+
MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS:
306+
Base10.toString(cfg.MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS),
308307

309308
# https://github.com/ethereum/consensus-specs/blob/v1.4.0-alpha.3/specs/phase0/beacon-chain.md#constants
310309
# GENESIS_SLOT

beacon_chain/spec/presets.nim

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ when const_preset == "mainnet":
328328
VALIDATOR_CUSTODY_REQUIREMENT: 8,
329329
BALANCE_PER_ADDITIONAL_CUSTODY_GROUP: 32000000000'u64,
330330
MAX_BLOBS_PER_BLOCK_FULU: 12,
331-
MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS: 4096
331+
MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS: 4096,
332332
# https://github.com/ethereum/consensus-specs/blob/v1.6.0-alpha.0/specs/fulu/das-core.md#get_max_blobs_per_block
333333
# provides sorting rules.
334334
BLOB_SCHEDULE: @[
@@ -668,7 +668,7 @@ elif const_preset == "minimal":
668668
VALIDATOR_CUSTODY_REQUIREMENT: 8,
669669
BALANCE_PER_ADDITIONAL_CUSTODY_GROUP: 32000000000'u64,
670670
MAX_BLOBS_PER_BLOCK_FULU: 12,
671-
MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS: 4096
671+
MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS: 4096,
672672
# https://github.com/ethereum/consensus-specs/blob/v1.6.0-alpha.0/specs/fulu/das-core.md#get_max_blobs_per_block
673673
# provides sorting rules.
674674
BLOB_SCHEDULE: @[

0 commit comments

Comments
 (0)