Beacon node startup cleanups (#7665)

* Beacon node startup cleanups

* KZG can now be loaded lazily - at the same time, normalise command
line parameter for using a different setup to use `--debug` prefix like
all other hidden options, allowing the option can be shared between
eth1/eth2
* move init logic around so that "main thread" / process-related
initialization has its own home that is not shared with libraries
* make init fail gracefully (instead of quitting)
* remove error handling made redundant by `async` raises

* test fixes

* more tests

* eh

Author: arnetheduck

beacon_chain/conf.nim

@@ -22,7 +22,6 @@ import
   eth/enr/enr,
   json_serialization, json_serialization/std/net as jsnet, web3/confutils_defs,
   chronos/transports/common,
-  kzg4844/kzg,
   ./spec/[engine_authentication, keystore, network, crypto],
   ./spec/datatypes/base,
   ./networking/network_metadata,
@@ -680,13 +679,12 @@ type
         defaultValue: HistoryMode.Prune
         name: "history".}: HistoryMode
 
-      # https://notes.ethereum.org/@bbusa/dencun-devnet-6
-      # "Please ensure that there is a way for us to specify the file through a
-      # runtime flag such as --trusted-setup-file (or similar)."
       trustedSetupFile* {.
         hidden
-        desc: "Experimental, debug option; could disappear at any time without warning"
-        name: "temporary-debug-trusted-setup-file" .}: Option[string]
+        desc: "Alternative EIP-4844 trusted setup file"
+        defaultValue: none(string)
+        defaultValueDesc: "Baked in trusted setup"
+        name: "debug-trusted-setup-file" .}: Option[string]
 
       bandwidthEstimate* {.
         hidden
@@ -760,11 +758,6 @@ type
           desc: "Output wallet file"
           name: "new-wallet-file" .}: Option[OutFile]
 
-      #[
-      of DepositsCmd.status:
-        discard
-      ]#
-
       of DepositsCmd.`import`:
         importedDepositsDir* {.
           argument
@@ -1530,16 +1523,6 @@ proc engineApiUrls*(config: auto): seq[EngineApiUrl] =
   (elUrls & config.web3Urls).toFinalEngineApiUrls(
     config.jwtSecret.configJwtSecretOpt)
 
-proc loadKzgTrustedSetup*(): Result[void, string] =
-  static: doAssert const_preset in ["mainnet", "gnosis", "minimal"]
-  loadTrustedSetupFromString(kzg.trustedSetup, 0)
-
-proc loadKzgTrustedSetup*(trustedSetupPath: string): Result[void, string] =
-  try:
-    loadTrustedSetupFromString(readFile(trustedSetupPath), 0)
-  except IOError as err:
-    err(err.msg)
-
 proc formatIt*(v: Option[IpAddress]): string =
   if v.isSome():
     $v.get()