Merge pull request #178 from staticdev/bugfix/pipx-and-ansible-lint-errors

Bugfix/pipx and ansible lint errors

Author: staticdev

.ansible-lint

@@ -1,5 +1,3 @@
-exclude_paths: ~/.ansible
-
 skip_list:
   - '306'
   - '106'

.pre-commit-config.yaml

@@ -1,7 +1,7 @@
 ---
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.0.1
+    rev: v4.3.0
     hooks:
       - id: check-added-large-files
       - id: check-toml
@@ -10,15 +10,15 @@ repos:
       - id: trailing-whitespace
       - id: check-added-large-files
   - repo: https://github.com/pre-commit/mirrors-prettier
-    rev: v2.5.1
+    rev: v2.7.1
     hooks:
       - id: prettier
   - repo: https://github.com/adrienverge/yamllint.git
-    rev: v1.26.3
+    rev: v1.28.0
     hooks:
       - id: yamllint
         args: [-c=.yamllint]
   - repo: https://github.com/ansible-community/ansible-lint.git
-    rev: v5.3.1
+    rev: v6.8.0
     hooks:
       - id: ansible-lint

handlers/main.yml

@@ -1,5 +1,5 @@
 ---
 - name: delete poetry installer
-  file:
+  ansible.builtin.file:
     path: "/home/{{ lookup('env', 'USER') }}/install-poetry.py"
     state: absent

meta/main.yml

@@ -6,7 +6,7 @@ galaxy_info:
 
   license: MIT
 
-  min_ansible_version: 2.11
+  min_ansible_version: "2.11"
 
   platforms:
     - name: Debian
@@ -28,7 +28,7 @@ galaxy_info:
     - poetry
     - pyenv
     - pipx
-    - pre-commit
+    - precommit
     - workstation
 
 dependencies:

molecule/default/converge.yml

@@ -6,10 +6,16 @@
 
   pre_tasks:
     - name: Update apt cache.
-      apt: update_cache=yes cache_valid_time=600
+      ansible.builtin.apt: update_cache=yes cache_valid_time=600
       when: ansible_os_family == 'Debian'
 
+    # https://askubuntu.com/questions/1428181/module-lib-has-no-attribute-x509-v-flag-cb-issuer-check
+    - name: Update pyOpenSSL.
+      ansible.builtin.pip:
+        name: pyOpenSSL
+        extra_args: --upgrade
+
   tasks:
     - name: "Include staticdev.python_developer"
-      include_role:
+      ansible.builtin.include_role:
         name: "staticdev.python_developer"

tasks/main.yml

@@ -1,14 +1,14 @@
 ---
 - name: Install pyenv
-  import_role:
+  ansible.builtin.import_role:
     name: staticdev.pyenv
   vars:
     pyenv_owner: "{{ ansible_env.USER }}"
     pyenv_path: "{{ ansible_env.HOME }}/pyenv"
   when: pyenv_python_versions
 
 - name: Ensure dependencies are installed
-  package:
+  ansible.builtin.package:
     name: "{{ item }}"
     state: present
   become: true
@@ -17,46 +17,46 @@
     - python3-venv # needed for nox
 
 - name: Check if pipx is installed
-  command: "{{ ansible_env.HOME }}/.local/bin/pipx --version"
+  ansible.builtin.command: "{{ ansible_env.HOME }}/.local/bin/pipx --version"
   register: pipx_version_cmd
   changed_when: false
   ignore_errors: true
 
 - name: Install pipx
-  pip:
+  ansible.builtin.pip:
     name: pipx
     extra_args: --user
   when: pipx_version_cmd is failed
 
 - name: Check if pre-commit is installed
-  command: "{{ ansible_env.HOME }}/.local/bin/pre-commit --version"
+  ansible.builtin.command: "{{ ansible_env.HOME }}/.local/bin/pre-commit --version"
   register: pre_commit_check
   changed_when: false
   ignore_errors: true
 
 - name: Install pre-commit
-  command: "{{ ansible_env.HOME }}/.local/bin/pipx install pre-commit"
+  ansible.builtin.command: "{{ ansible_env.HOME }}/.local/bin/pipx install pre-commit"
   register: output
   when: pre_commit_check is failed
 
 - name: Check if cookiecutter is installed
-  stat:
+  ansible.builtin.stat:
     path: "{{ ansible_env.HOME }}/.local/pipx/venvs/cookiecutter"
   register: cookiecutter_folder_check
 
 - name: Install cookiecutter
-  command: "{{ ansible_env.HOME }}/.local/bin/pipx install cookiecutter"
+  ansible.builtin.command: "{{ ansible_env.HOME }}/.local/bin/pipx install cookiecutter"
   register: output
   when: cookiecutter_folder_check is failed
 
 - name: Check if poetry is installed
-  command: "{{ ansible_env.HOME }}/.local/bin/poetry"
+  ansible.builtin.command: "{{ ansible_env.HOME }}/.local/bin/poetry"
   register: poetry_cmd
   changed_when: false
   ignore_errors: true
 
 - name: Download poetry installer
-  get_url:
+  ansible.builtin.get_url:
     url: https://raw.githubusercontent.com/python-poetry/poetry/master/install-poetry.py
     dest: "{{ ansible_env.HOME }}/install-poetry.py"
     mode: "0400"
@@ -65,19 +65,19 @@
   notify: delete poetry installer
 
 - name: Install poetry
-  command: "python3 {{ ansible_env.HOME }}/install-poetry.py"
+  ansible.builtin.command: "python3 {{ ansible_env.HOME }}/install-poetry.py"
   when: poetry_cmd is failed
 
 - name: Check if nox is installed
-  command: "{{ ansible_env.HOME }}/.local/bin/nox --version"
+  ansible.builtin.command: "{{ ansible_env.HOME }}/.local/bin/nox --version"
   register: nox_version_cmd
   changed_when: false
   ignore_errors: true
 
 - name: Install nox
-  command: "{{ ansible_env.HOME }}/.local/bin/pipx install nox"
+  ansible.builtin.command: "{{ ansible_env.HOME }}/.local/bin/pipx install nox"
   when: nox_version_cmd is failed
 
 - name: Install nox-poetry
-  command: "{{ ansible_env.HOME }}/.local/bin/pipx inject nox nox-poetry"
+  ansible.builtin.command: "{{ ansible_env.HOME }}/.local/bin/pipx inject nox nox-poetry"
   when: nox_version_cmd is failed