Skip to content

Commit 869e4e6

Browse files
authored
add spike environment variable for config file ease (#253)
1 parent 9beaead commit 869e4e6

File tree

4 files changed

+5
-2
lines changed

4 files changed

+5
-2
lines changed

lib/config.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -262,6 +262,7 @@ module.exports = class Config {
262262
* @return {Object} validated spike options object
263263
*/
264264
parseAppJs (opts) {
265+
if (opts.env) { process.env.SPIKE_ENV = opts.env }
265266
let config = loadFile(path.resolve(opts.root, 'app.js'))
266267

267268
if (opts.env) {

test/environments.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@ const {compileFixture} = require('./_helpers')
33

44
test('environment config parsed correctly', (t) => {
55
return compileFixture(t, 'environments', { env: 'doge' }).then(({res}) => {
6+
t.is(res.stats.compilation.options.entry.doge1[0], 'doge')
67
t.is(res.stats.compilation.options.entry.doge2[0], 'very')
78
t.is(res.stats.compilation.options.entry.doge3[0], 'amaze')
9+
t.is(res.stats.compilation.options.entry.doge4[0], 'doge')
810
})
911
})
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
module.exports = {
2-
entry: { doge3: 'amaze' }
2+
entry: { doge3: 'amaze', doge4: process.env.SPIKE_ENV }
33
}

test/fixtures/environments/app.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
module.exports = {
2-
entry: { doge2: 'very' }
2+
entry: { doge2: 'very', doge1: process.env.SPIKE_ENV }
33
}

0 commit comments

Comments
 (0)