FormSubmission transform should return a DataCollection not a normal collection (#477)

Author: ryanmitchell

src/Forms/SubmissionQueryBuilder.php

@@ -3,6 +3,7 @@
 namespace Statamic\Eloquent\Forms;
 
 use Statamic\Contracts\Forms\SubmissionQueryBuilder as BuilderContract;
+use Statamic\Data\DataCollection;
 use Statamic\Facades\Form;
 use Statamic\Query\EloquentQueryBuilder;
 use Statamic\Support\Str;
@@ -34,7 +35,7 @@ protected function column($column)
 
     protected function transform($items, $columns = [])
     {
-        return $items->map(function ($model) {
+        return DataCollection::make($items)->map(function ($model) {
             return Submission::fromModel($model)
                 ->form(Form::find($model->form));
         });

tests/Forms/FormSubmissionTest.php

@@ -5,7 +5,9 @@
 use Carbon\Carbon;
 use Illuminate\Support\Facades\Event;
 use PHPUnit\Framework\Attributes\Test;
+use Statamic\Data\DataCollection;
 use Statamic\Eloquent\Forms\FormModel;
+use Statamic\Eloquent\Forms\Submission;
 use Statamic\Eloquent\Forms\SubmissionModel;
 use Statamic\Events\SubmissionCreated;
 use Statamic\Events\SubmissionDeleted;
@@ -169,4 +171,19 @@ public function it_should_delete_quietly()
         Event::assertDispatched(SubmissionDeleted::class);
         $this->assertSame($result, true);
     }
+
+    #[Test]
+    public function querying_submissions_should_return_data_collections()
+    {
+        $form = Facades\Form::make('test');
+
+        $form->makeSubmission([
+            'name' => 'John Doe',
+        ])->save();
+
+        $submissions = $form->querySubmissions()->get();
+
+        $this->assertInstanceOf(DataCollection::class, $submissions);
+        $this->assertEveryItemIsInstanceOf(Submission::class, $submissions);
+    }
 }