chore: update supported RPC errors for RPC v0.8.0-rc3 (#1339)

Author: penovicp

__tests__/account.test.ts

@@ -363,22 +363,27 @@ describe('deploy and test Wallet', () => {
     expect(balance.low).toStrictEqual(toBigInt(990));
   });
 
-  // TODO: @penovicp this is your space, for some reson this return Object, disabled at the moment
-  xtest('execute with and without deprecated abis parameter', async () => {
+  test('execute with and without deprecated abis parameter', async () => {
     const transaction = {
       contractAddress: erc20Address,
       entrypoint: 'transfer',
       calldata: [erc20.address, '10', '0'],
     };
-    const details = { maxFee: 0n };
+    const details: Parameters<(typeof account)['execute']>[2] = { nonce: 0 };
 
-    const error1: RpcError = await account.execute(transaction, details).catch((e) => e);
+    let error1: RpcError | undefined;
+    // eslint-disable-next-line no-return-assign
+    await account.execute(transaction, details).catch((e) => (error1 = e));
+    expect(error1).toBeDefined();
     expect(error1).toBeInstanceOf(RpcError);
-    expect(error1.isType('INSUFFICIENT_MAX_FEE')).toBe(true);
+    expect(error1!.isType('TRANSACTION_EXECUTION_ERROR')).toBe(true);
 
-    const error2: RpcError = await account.execute(transaction, undefined, details).catch((e) => e);
+    let error2: RpcError | undefined;
+    // eslint-disable-next-line no-return-assign
+    await account.execute(transaction, undefined, details).catch((e) => (error2 = e));
+    expect(error2).toBeDefined();
     expect(error2).toBeInstanceOf(RpcError);
-    expect(error2.isType('INSUFFICIENT_MAX_FEE')).toBe(true);
+    expect(error2!.isType('TRANSACTION_EXECUTION_ERROR')).toBe(true);
   });
 
   test('execute with custom nonce', async () => {

__tests__/utils/errors.test.ts

@@ -2,7 +2,6 @@ import { RPC, RpcError } from '../../src';
 
 describe('Error utility tests', () => {
   test('RpcError', () => {
-    // TODO: @penovicp types 0.8 exporta u top level sve 0.7 exporta po komponentama, neznan jeli treba minjat test i mod da ocukuje oba tipa
     const baseError: RPC.RPCSPEC08.UNEXPECTED_ERROR = {
       code: 63,
       message: 'An unexpected error occurred',

package-lock.json

@@ -90,7 +90,7 @@
     "prettier": "^3.2.5",
     "prettier-plugin-import-sort": "^0.0.7",
     "semantic-release": "^24.0.0",
-    "starknet_specs": "github:starkware-libs/starknet-specs#v0.7.1",
+    "starknet_specs": "github:starkware-libs/starknet-specs#v0.8.0-rc3",
     "tsup": "^8.0.2",
     "type-coverage": "^2.28.2",
     "typescript": "~5.7.0",

package.json

@@ -4,14 +4,18 @@
 // - src/utils/errors/rpc.ts
 
 const starknet_api_openrpc = require('starknet_specs/api/starknet_api_openrpc.json');
+const starknet_executables = require('starknet_specs/api/starknet_executables.json');
 const starknet_trace_api_openrpc = require('starknet_specs/api/starknet_trace_api_openrpc.json');
 const starknet_write_api = require('starknet_specs/api/starknet_write_api.json');
+const starknet_ws_api = require('starknet_specs/api/starknet_ws_api.json');
 
 const errorNameCodeMap = Object.fromEntries(
   Object.entries({
+    ...starknet_api_openrpc.components.errors,
+    ...starknet_executables.components.errors,
     ...starknet_trace_api_openrpc.components.errors,
     ...starknet_write_api.components.errors,
-    ...starknet_api_openrpc.components.errors,
+    ...starknet_ws_api.components.errors,
   })
     .map((e) => [e[0], e[1].code])
     .sort((a, b) => a[1] - b[1])

scripts/generateRpcErrorMap.js

@@ -1,10 +1,11 @@
-import { Errors } from 'starknet-types-07';
+import * as Errors from 'starknet-types-08';
 
 // NOTE: generated with scripts/generateRpcErrorMap.js
 export type RPC_ERROR_SET = {
   FAILED_TO_RECEIVE_TXN: Errors.FAILED_TO_RECEIVE_TXN;
   NO_TRACE_AVAILABLE: Errors.NO_TRACE_AVAILABLE;
   CONTRACT_NOT_FOUND: Errors.CONTRACT_NOT_FOUND;
+  ENTRYPOINT_NOT_FOUND: Errors.ENTRYPOINT_NOT_FOUND;
   BLOCK_NOT_FOUND: Errors.BLOCK_NOT_FOUND;
   INVALID_TXN_INDEX: Errors.INVALID_TXN_INDEX;
   CLASS_HASH_NOT_FOUND: Errors.CLASS_HASH_NOT_FOUND;
@@ -15,9 +16,10 @@ export type RPC_ERROR_SET = {
   TOO_MANY_KEYS_IN_FILTER: Errors.TOO_MANY_KEYS_IN_FILTER;
   CONTRACT_ERROR: Errors.CONTRACT_ERROR;
   TRANSACTION_EXECUTION_ERROR: Errors.TRANSACTION_EXECUTION_ERROR;
+  STORAGE_PROOF_NOT_SUPPORTED: Errors.STORAGE_PROOF_NOT_SUPPORTED;
   CLASS_ALREADY_DECLARED: Errors.CLASS_ALREADY_DECLARED;
   INVALID_TRANSACTION_NONCE: Errors.INVALID_TRANSACTION_NONCE;
-  INSUFFICIENT_MAX_FEE: Errors.INSUFFICIENT_MAX_FEE;
+  INSUFFICIENT_RESOURCES_FOR_VALIDATE: Errors.INSUFFICIENT_RESOURCES_FOR_VALIDATE;
   INSUFFICIENT_ACCOUNT_BALANCE: Errors.INSUFFICIENT_ACCOUNT_BALANCE;
   VALIDATION_FAILURE: Errors.VALIDATION_FAILURE;
   COMPILATION_FAILED: Errors.COMPILATION_FAILED;
@@ -28,6 +30,10 @@ export type RPC_ERROR_SET = {
   UNSUPPORTED_TX_VERSION: Errors.UNSUPPORTED_TX_VERSION;
   UNSUPPORTED_CONTRACT_CLASS_VERSION: Errors.UNSUPPORTED_CONTRACT_CLASS_VERSION;
   UNEXPECTED_ERROR: Errors.UNEXPECTED_ERROR;
+  INVALID_SUBSCRIPTION_ID: Errors.INVALID_SUBSCRIPTION_ID;
+  TOO_MANY_ADDRESSES_IN_FILTER: Errors.TOO_MANY_ADDRESSES_IN_FILTER;
+  TOO_MANY_BLOCKS_BACK: Errors.TOO_MANY_BLOCKS_BACK;
+  COMPILATION_ERROR: Errors.COMPILATION_ERROR;
 };
 
 export type RPC_ERROR = RPC_ERROR_SET[keyof RPC_ERROR_SET];

src/types/errors.ts

@@ -5,6 +5,7 @@ const errorCodes: { [K in keyof RPC_ERROR_SET]: RPC_ERROR_SET[K]['code'] } = {
   FAILED_TO_RECEIVE_TXN: 1,
   NO_TRACE_AVAILABLE: 10,
   CONTRACT_NOT_FOUND: 20,
+  ENTRYPOINT_NOT_FOUND: 21,
   BLOCK_NOT_FOUND: 24,
   INVALID_TXN_INDEX: 27,
   CLASS_HASH_NOT_FOUND: 28,
@@ -15,9 +16,10 @@ const errorCodes: { [K in keyof RPC_ERROR_SET]: RPC_ERROR_SET[K]['code'] } = {
   TOO_MANY_KEYS_IN_FILTER: 34,
   CONTRACT_ERROR: 40,
   TRANSACTION_EXECUTION_ERROR: 41,
+  STORAGE_PROOF_NOT_SUPPORTED: 42,
   CLASS_ALREADY_DECLARED: 51,
   INVALID_TRANSACTION_NONCE: 52,
-  INSUFFICIENT_MAX_FEE: 53,
+  INSUFFICIENT_RESOURCES_FOR_VALIDATE: 53,
   INSUFFICIENT_ACCOUNT_BALANCE: 54,
   VALIDATION_FAILURE: 55,
   COMPILATION_FAILED: 56,
@@ -28,5 +30,9 @@ const errorCodes: { [K in keyof RPC_ERROR_SET]: RPC_ERROR_SET[K]['code'] } = {
   UNSUPPORTED_TX_VERSION: 61,
   UNSUPPORTED_CONTRACT_CLASS_VERSION: 62,
   UNEXPECTED_ERROR: 63,
+  INVALID_SUBSCRIPTION_ID: 66,
+  TOO_MANY_ADDRESSES_IN_FILTER: 67,
+  TOO_MANY_BLOCKS_BACK: 68,
+  COMPILATION_ERROR: 100,
 };
 export default errorCodes;