Skip to content

Commit 65bea53

Browse files
committed
fix: utilize provided resourceBounds value
1 parent bfedce9 commit 65bea53

File tree

2 files changed

+25
-5
lines changed

2 files changed

+25
-5
lines changed

__tests__/utils/stark.test.ts

Lines changed: 23 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import { CallData, RawArgs, json, stark } from '../../src';
2-
import { FeeEstimate } from '../../src/types/api';
1+
import { CallData, RawArgs, UniversalDetails, json, stark } from '../../src';
2+
import { EDataAvailabilityMode, FeeEstimate } from '../../src/types/api';
33
import { toBigInt, toHex } from '../../src/utils/num';
44
import { compiledOpenZeppelinAccount } from '../config/fixtures';
55

@@ -83,4 +83,25 @@ describe('stark', () => {
8383
l1_gas: { max_amount: '0x6e', max_price_per_unit: '0xf' },
8484
});
8585
});
86+
87+
test('v3Details', () => {
88+
const setValues = (o: {}, v: any) => Object.fromEntries(Object.keys(o).map((k) => [k, v]));
89+
90+
const details: UniversalDetails = {
91+
tip: 99n,
92+
paymasterData: [99n, 99n],
93+
accountDeploymentData: [99n, 99n],
94+
nonceDataAvailabilityMode: EDataAvailabilityMode.L2,
95+
feeDataAvailabilityMode: EDataAvailabilityMode.L2,
96+
resourceBounds: {
97+
l1_gas: { max_amount: '0x99', max_price_per_unit: '0x99' },
98+
l2_gas: { max_amount: '0x99', max_price_per_unit: '0x99' },
99+
},
100+
};
101+
const detailsUndefined = setValues(details, undefined);
102+
const detailsAnything = setValues(details, expect.anything());
103+
104+
expect(stark.v3Details(details)).toMatchObject(details);
105+
expect(stark.v3Details(detailsUndefined)).toEqual(expect.objectContaining(detailsAnything));
106+
});
86107
});

src/utils/stark.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -171,8 +171,7 @@ export function toFeeVersion(providedVersion?: BigNumberish) {
171171
}
172172

173173
/**
174-
* Rerturn provided or default v3 tx details
175-
* @param details EstimateFeeDetails
174+
* Return provided or default v3 tx details
176175
*/
177176
export function v3Details(details: UniversalDetails) {
178177
return {
@@ -181,7 +180,7 @@ export function v3Details(details: UniversalDetails) {
181180
accountDeploymentData: details.accountDeploymentData || [],
182181
nonceDataAvailabilityMode: details.nonceDataAvailabilityMode || EDataAvailabilityMode.L1,
183182
feeDataAvailabilityMode: details.feeDataAvailabilityMode || EDataAvailabilityMode.L1,
184-
resourceBounds: estimateFeeToBounds(ZERO),
183+
resourceBounds: details.resourceBounds ?? estimateFeeToBounds(ZERO),
185184
};
186185
}
187186

0 commit comments

Comments
 (0)