Merge pull request #938 from sysid/main

fix(dsp): indicate other completions only if choices is list, not string

Author: arnavsinghvi11

dsp/modules/aws_models.py

@@ -49,6 +49,9 @@ def __init__(
         self._max_context_size: int = max_context_size
         self._max_new_tokens: int = max_new_tokens
 
+        # make it consistent with equivalent LM::max_token
+        self.kwargs["max_tokens"] = max_new_tokens
+
         self.kwargs = {
             **self.kwargs,
             **kwargs,
@@ -63,7 +66,7 @@ def _call_model(self, body: str) -> str | list[str]:
         """Call model, get generated input without the formatted prompt."""
 
     def _estimate_tokens(self, text: str) -> int:
-        return len(text)/CHARS2TOKENS
+        return len(text) / CHARS2TOKENS
 
     def _extract_input_parameters(
         self,

dsp/modules/lm.py

@@ -76,8 +76,8 @@ def inspect_history(self, n: int = 1, skip: int = 0):
                 text = choices
             elif provider == "openai" or provider == "ollama":
                 text = ' ' + self._get_choice_text(choices[0]).strip()
-            elif provider == "clarifai" or provider == "claude" :
-                text=choices
+            elif provider == "clarifai" or provider == "claude":
+                text = choices
             elif provider == "groq":
                 text = ' ' + choices
             elif provider == "google":
@@ -88,7 +88,7 @@ def inspect_history(self, n: int = 1, skip: int = 0):
                 text = choices[0]["text"]
             printing_value += self.print_green(text, end="")
 
-            if len(choices) > 1:
+            if len(choices) > 1 and isinstance(choices, list):
                 printing_value += self.print_red(f" \t (and {len(choices)-1} other completions)", end="")
 
             printing_value += "\n\n\n"