try skipping visual tests on r-devel

Author: jgabry

.github/workflows/R-CMD-check.yaml

@@ -31,6 +31,7 @@ jobs:
     env:
       GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
       R_KEEP_PKG_SOURCE: yes
+      R_VERSION_TYPE: ${{ matrix.config.r }}
 
     steps:
       - uses: actions/checkout@v3

tests/testthat/helper.R

@@ -0,0 +1,7 @@
+# used to skip visual tests of SVGs on r-devel and r-oldrel
+# because they can be slightly different than r-release occasionally
+skip_if_not_r_release <- function() {
+  testthat::skip_if(isTRUE(Sys.getenv("R_VERSION_TYPE") == "devel"))
+
+  #testthat::skip_if_not(isTRUE(Sys.getenv("R_VERSION_TYPE") == "release"))
+}

tests/testthat/test-aesthetics.R

@@ -219,6 +219,7 @@ color_scheme_set()
 test_that("color_scheme_view renders correctly", {
   testthat::skip_on_cran()
   testthat::skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   color_scheme_set()
   p_default <- color_scheme_view()

tests/testthat/test-mcmc-diagnostics.R

@@ -109,6 +109,7 @@ test_that("mcmc_acf & mcmc_acf_bar throw correct errors", {
 test_that("mcmc_rhat renders correctly", {
   testthat::skip_on_cran()
   testthat::skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   rhats <- seq(from = 1, to = 1.20, length.out = 10)
 
@@ -122,6 +123,7 @@ test_that("mcmc_rhat renders correctly", {
 test_that("mcmc_rhat_hist renders correctly", {
   testthat::skip_on_cran()
   testthat::skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   rhats <- seq(from = 1, to = 1.20, length.out = 10)
 
@@ -136,6 +138,7 @@ test_that("mcmc_rhat_hist renders correctly", {
 test_that("mcmc_neff renders correctly", {
   testthat::skip_on_cran()
   testthat::skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   neffs <- seq(from = 0, to = 1, length.out = 20)
 
@@ -146,6 +149,7 @@ test_that("mcmc_neff renders correctly", {
 test_that("mcmc_neff_hist renders correctly", {
   testthat::skip_on_cran()
   testthat::skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   neffs <- seq(from = 0, to = 1, length.out = 20)
 
@@ -159,6 +163,7 @@ test_that("mcmc_neff_hist renders correctly", {
 test_that("mcmc_acf renders correctly", {
   testthat::skip_on_cran()
   testthat::skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   p_base <- mcmc_acf(vdiff_dframe)
   vdiffr::expect_doppelganger("mcmc_acf (default)", p_base)
@@ -170,6 +175,7 @@ test_that("mcmc_acf renders correctly", {
 test_that("mcmc_acf_bar renders correctly", {
   testthat::skip_on_cran()
   testthat::skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   p_base <- mcmc_acf_bar(vdiff_dframe)
   vdiffr::expect_doppelganger("mcmc_acf_bar (default)", p_base)

tests/testthat/test-mcmc-distributions.R

@@ -124,6 +124,7 @@ test_that("mcmc_* throws error if 1 chain but multiple chains required", {
 test_that("mcmc_hist renders correctly", {
   testthat::skip_on_cran()
   testthat::skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   p_base <- mcmc_hist(vdiff_dframe, binwidth = 0.1)
   vdiffr::expect_doppelganger("mcmc_hist (default)", p_base)
@@ -138,6 +139,7 @@ test_that("mcmc_hist renders correctly", {
 test_that("mcmc_dens renders correctly", {
   testthat::skip_on_cran()
   testthat::skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   p_base <- mcmc_dens(vdiff_dframe)
   vdiffr::expect_doppelganger("mcmc_dens (default)", p_base)
@@ -149,6 +151,7 @@ test_that("mcmc_dens renders correctly", {
 test_that("mcmc_dens_overlay renders correctly", {
   testthat::skip_on_cran()
   testthat::skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   p_base <- mcmc_dens_overlay(vdiff_dframe_chains)
   vdiffr::expect_doppelganger("mcmc_dens_overlay (default)", p_base)
@@ -157,6 +160,7 @@ test_that("mcmc_dens_overlay renders correctly", {
 test_that("mcmc_dens_chains renders correctly", {
   testthat::skip_on_cran()
   testthat::skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   p_base <- mcmc_dens_chains(vdiff_dframe_chains)
   vdiffr::expect_doppelganger("mcmc_dens_chains (default)", p_base)
@@ -165,6 +169,7 @@ test_that("mcmc_dens_chains renders correctly", {
 test_that("mcmc_hist_by_chain renders correctly", {
   testthat::skip_on_cran()
   testthat::skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   p_base <- mcmc_hist_by_chain(vdiff_dframe_chains, binwidth = 0.5)
   vdiffr::expect_doppelganger("mcmc_hist_by_chain (default)", p_base)
@@ -173,6 +178,7 @@ test_that("mcmc_hist_by_chain renders correctly", {
 test_that("mcmc_violin renders correctly", {
   testthat::skip_on_cran()
   testthat::skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   p_base <- mcmc_violin(vdiff_dframe_chains)
   vdiffr::expect_doppelganger("mcmc_violin (default)", p_base)

tests/testthat/test-mcmc-intervals.R

@@ -178,6 +178,7 @@ test_that("inconsistent probabilities raise warning (#138)", {
 test_that("mcmc_intervals renders correctly", {
   testthat::skip_on_cran()
   testthat::skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   p_base <- mcmc_intervals(vdiff_dframe)
   vdiffr::expect_doppelganger("mcmc_intervals (default)", p_base)
@@ -205,6 +206,7 @@ test_that("mcmc_intervals renders correctly", {
 test_that("mcmc_areas renders correctly", {
   testthat::skip_on_cran()
   testthat::skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   p_base <- mcmc_areas(vdiff_dframe)
   vdiffr::expect_doppelganger("mcmc_areas (default)", p_base)
@@ -238,6 +240,7 @@ test_that("mcmc_areas renders correctly", {
 test_that("mcmc_areas_ridges renders correctly", {
   testthat::skip_on_cran()
   testthat::skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   p_base <- mcmc_areas_ridges(vdiff_dframe)
   vdiffr::expect_doppelganger("mcmc_areas_ridges (default)", p_base)

tests/testthat/test-mcmc-nuts.R

@@ -97,6 +97,7 @@ source(test_path("data-for-mcmc-tests.R"))
 test_that("mcmc_nuts_acceptance renders correctly", {
   skip_on_cran()
   skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   p_base <- mcmc_nuts_acceptance(vdiff_dframe_chains_np, vdiff_dframe_chains_lp)
   vdiffr::expect_doppelganger("mcmc_nuts_acceptance (default)", p_base)
@@ -108,6 +109,7 @@ test_that("mcmc_nuts_acceptance renders correctly", {
 test_that("mcmc_nuts_divergence renders correctly", {
   skip_on_cran()
   skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   p_base <- mcmc_nuts_divergence(vdiff_dframe_chains_np, vdiff_dframe_chains_lp)
   vdiffr::expect_doppelganger("mcmc_nuts_divergence (default)", p_base)
@@ -119,6 +121,7 @@ test_that("mcmc_nuts_divergence renders correctly", {
 test_that("mcmc_nuts_treedepth renders correctly", {
   skip_on_cran()
   skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   p_base <- mcmc_nuts_treedepth(vdiff_dframe_chains_np, vdiff_dframe_chains_lp)
   vdiffr::expect_doppelganger("mcmc_nuts_treedepth (default)", p_base)
@@ -130,6 +133,7 @@ test_that("mcmc_nuts_treedepth renders correctly", {
 test_that("mcmc_nuts_stepsize renders correctly", {
   skip_on_cran()
   skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   p_base <- mcmc_nuts_stepsize(vdiff_dframe_chains_np, vdiff_dframe_chains_lp)
   vdiffr::expect_doppelganger("mcmc_nuts_stepsize (default)", p_base)
@@ -141,6 +145,7 @@ test_that("mcmc_nuts_stepsize renders correctly", {
 test_that("mcmc_nuts_energy renders correctly", {
   skip_on_cran()
   skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   p_base <- mcmc_nuts_energy(vdiff_dframe_chains_np, vdiff_dframe_chains_lp, binwidth = 10)
   vdiffr::expect_doppelganger("mcmc_nuts_energy (default)", p_base)

tests/testthat/test-mcmc-recover.R

@@ -106,6 +106,7 @@ test_that("mcmc_recover_hist returns a ggplot object", {
 test_that("mcmc_recover_hist renders correctly", {
   skip_on_cran()
   skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   p_base <- mcmc_recover_hist(draws, true, binwidth = 0.01)
   vdiffr::expect_doppelganger("mcmc_recover_hist (default)", p_base)
@@ -114,6 +115,7 @@ test_that("mcmc_recover_hist renders correctly", {
 test_that("mcmc_recover_intervals renders correctly", {
   skip_on_cran()
   skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   p_base <- mcmc_recover_intervals(draws, true)
   vdiffr::expect_doppelganger("mcmc_recover_intervals (default)", p_base)
@@ -125,6 +127,7 @@ test_that("mcmc_recover_intervals renders correctly", {
 test_that("mcmc_recover_scatter renders correctly", {
   skip_on_cran()
   skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   p_base <- mcmc_recover_scatter(draws, true)
   vdiffr::expect_doppelganger("mcmc_recover_scatter (default)", p_base)

tests/testthat/test-mcmc-scatter-and-parcoord.R

@@ -373,6 +373,7 @@ test_that("parcoord_style_np throws correct errors", {
 test_that("mcmc_scatter renders correctly", {
   skip_on_cran()
   skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   p_base <- mcmc_scatter(vdiff_dframe_chains)
   vdiffr::expect_doppelganger("mcmc_scatter (default)", p_base)
@@ -395,6 +396,7 @@ test_that("mcmc_hex renders correctly", {
   skip_on_cran()
   skip_if_not_installed("vdiffr")
   skip_if_not_installed("hexbin")
+  skip_if_not_r_release()
 
   p_base <- mcmc_hex(vdiff_dframe, pars = c("V1", "V2"))
   vdiffr::expect_doppelganger("mcmc_hex (default)", p_base)
@@ -410,6 +412,7 @@ test_that("mcmc_hex renders correctly", {
 test_that("mcmc_parcoord renders correctly", {
   skip_on_cran()
   skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   p_base <- mcmc_parcoord(vdiff_dframe_chains)
   vdiffr::expect_doppelganger("mcmc_parcoord (default)", p_base)
@@ -427,6 +430,7 @@ test_that("mcmc_pairs renders correctly", {
   skip_on_cran()
   skip_if_not_installed("vdiffr")
   skip_if_not_installed("hexbin")
+  skip_if_not_r_release()
 
   p_base <- mcmc_pairs(vdiff_dframe_chains)
   vdiffr::expect_doppelganger("mcmc_pairs (default)", p_base)

tests/testthat/test-mcmc-traces.R

@@ -116,6 +116,7 @@ test_that("mcmc_trace 'np' argument works", {
 test_that("mcmc_trace renders correctly", {
   testthat::skip_on_cran()
   testthat::skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   p_base <- mcmc_trace(vdiff_dframe_chains, pars = c("V1", "V2"))
   p_one_param <- mcmc_trace(vdiff_dframe_chains, pars = "V1")
@@ -138,6 +139,7 @@ test_that("mcmc_trace renders correctly", {
 test_that("mcmc_rank_overlay renders correctly", {
   testthat::skip_on_cran()
   testthat::skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   p_base <- mcmc_rank_overlay(vdiff_dframe_chains, pars = c("V1", "V2"))
   p_base_ref <- mcmc_rank_overlay(
@@ -167,6 +169,7 @@ test_that("mcmc_rank_overlay renders correctly", {
 test_that("mcmc_rank_hist renders correctly", {
   testthat::skip_on_cran()
   testthat::skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   p_base <- mcmc_rank_hist(vdiff_dframe_chains, pars = c("V1", "V2"))
   p_base_ref <- mcmc_rank_hist(
@@ -199,6 +202,7 @@ test_that("mcmc_rank_hist renders correctly", {
 test_that("mcmc_trace_highlight renders correctly", {
   testthat::skip_on_cran()
   testthat::skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   p_base <- mcmc_trace_highlight(
     vdiff_dframe_chains,
@@ -227,6 +231,7 @@ test_that("mcmc_trace_highlight renders correctly", {
 test_that("mcmc_rank_ecdf renders correctly", {
   testthat::skip_on_cran()
   testthat::skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   p_base <- mcmc_rank_ecdf(vdiff_dframe_chains, pars = c("V1", "V2"))
   p_one_param <- mcmc_rank_ecdf(vdiff_dframe_chains, pars = "V1")
@@ -255,6 +260,7 @@ test_that("mcmc_rank_ecdf renders correctly", {
 test_that("mcmc_trace with 'np' renders correctly", {
   testthat::skip_on_cran()
   testthat::skip_if_not_installed("vdiffr")
+  skip_if_not_r_release()
 
   p_base <- mcmc_trace(
     vdiff_dframe_chains,