Merge pull request #324 from stan-dev/expand-testing

Expand checking workflows to more platforms

Author: jgabry

.github/workflows/R-CMD-check.yaml

@@ -18,15 +18,20 @@ jobs:
       fail-fast: false
       matrix:
         config:
+          - {os: macos-latest,   r: 'devel'}
           - {os: macos-latest,   r: 'release'}
+          - {os: macos-latest,   r: 'oldrel'}
+          - {os: windows-latest, r: 'devel'}
           - {os: windows-latest, r: 'release'}
-          - {os: ubuntu-latest,   r: 'devel', http-user-agent: 'release'}
+          - {os: windows-latest, r: 'oldrel'}
+          - {os: ubuntu-latest,   r: 'devel'}
           - {os: ubuntu-latest,   r: 'release'}
-          - {os: ubuntu-latest,   r: 'oldrel-1'}
+          - {os: ubuntu-latest,   r: 'oldrel'}
 
     env:
       GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
       R_KEEP_PKG_SOURCE: yes
+      R_VERSION_TYPE: ${{ matrix.config.r }}
 
     steps:
       - uses: actions/checkout@v3
@@ -36,7 +41,6 @@ jobs:
       - uses: r-lib/actions/setup-r@v2
         with:
           r-version: ${{ matrix.config.r }}
-          http-user-agent: ${{ matrix.config.http-user-agent }}
           use-public-rspm: true
 
       - uses: r-lib/actions/setup-r-dependencies@v2

DESCRIPTION

@@ -55,7 +55,7 @@ Suggests:
     survival,
     testthat (>= 2.0.0),
     vdiffr (>= 1.0.2)
-RoxygenNote: 7.3.0
+RoxygenNote: 7.3.1
 VignetteBuilder: knitr
 Encoding: UTF-8
 Roxygen: list(markdown = TRUE)

R/ppc-distributions.R

@@ -550,7 +550,6 @@ ppc_violin_grouped <-
     args_violin_y <- list(
       data = function(x) dplyr::filter(x, .data$is_y),
       aes(fill = "y", color = "y"),
-      show.legend = FALSE,
       alpha = 0
     )
 
@@ -561,8 +560,7 @@ ppc_violin_grouped <-
       alpha = y_alpha,
       size = y_size,
       width = y_jitter,
-      height = 0,
-      show.legend = FALSE
+      height = 0
     )
 
     violin_y_func <- if (y_violin) geom_violin else geom_ignore

R/ppc-test-statistics.R

@@ -216,7 +216,7 @@ ppc_stat_freqpoly <-
       geom_vline(
         data = dplyr::filter(data, .data$variable == "y"),
         mapping = aes(xintercept = .data$value, color = "y"),
-        show.legend = FALSE,
+        show.legend = TRUE,
         linewidth = 1
       ) +
       scale_color_ppc(