stringifyArguments inserts '?' for unidentified arg

victor-homyakov · victor-homyakov · commit dbc03c7bf5fe · 2014-01-19T21:13:50.000+03:00
diff --git a/stacktrace.js b/stacktrace.js
@@ -298,6 +298,7 @@
                 } else if (arg === null) {
                     result[i] = 'null';
                 } else if (arg.constructor) {
+                    // TODO constructor comparison does not work for iframes
                     if (arg.constructor === Array) {
                         if (arg.length < 3) {
                             result[i] = '[' + this.stringifyArguments(arg) + ']';
@@ -312,6 +313,8 @@
                         result[i] = '"' + arg + '"';
                     } else if (arg.constructor === Number) {
                         result[i] = arg;
+                    } else {
+                        result[i] = '?';
                     }
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -298,6 +298,7 @@`
`298`	`298`	`} else if (arg === null) {`
`299`	`299`	`result[i] = 'null';`
`300`	`300`	`} else if (arg.constructor) {`
	`301`	`+ // TODO constructor comparison does not work for iframes`
`301`	`302`	`if (arg.constructor === Array) {`
`302`	`303`	`if (arg.length < 3) {`
`303`	`304`	`result[i] = '[' + this.stringifyArguments(arg) + ']';`
`@@ -312,6 +313,8 @@`
`312`	`313`	`result[i] = '"' + arg + '"';`
`313`	`314`	`} else if (arg.constructor === Number) {`
`314`	`315`	`result[i] = arg;`
	`316`	`+ } else {`
	`317`	`+ result[i] = '?';`
`315`	`318`	`}`
`316`	`319`	`}`
`317`	`320`	`}`