Skip to content

Commit aa25734

Browse files
Merge pull request #63 from yaroslavya/master
removed unneeded "else" statements
2 parents ae63f56 + f64010f commit aa25734

File tree

1 file changed

+19
-6
lines changed

1 file changed

+19
-6
lines changed

stacktrace.js

Lines changed: 19 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -66,13 +66,21 @@
6666
mode: function(e) {
6767
if (e['arguments'] && e.stack) {
6868
return 'chrome';
69-
} else if (e.stack && e.sourceURL) {
69+
}
70+
71+
if (e.stack && e.sourceURL) {
7072
return 'safari';
71-
} else if (e.stack && e.number) {
73+
}
74+
75+
if (e.stack && e.number) {
7276
return 'ie';
73-
} else if (e.stack && e.fileName) {
77+
}
78+
79+
if (e.stack && e.fileName) {
7480
return 'firefox';
75-
} else if (e.message && e['opera#sourceloc']) {
81+
}
82+
83+
if (e.message && e['opera#sourceloc']) {
7684
// e.message.indexOf("Backtrace:") > -1 -> opera9
7785
// 'opera#sourceloc' in e -> opera9, opera10a
7886
// !e.stacktrace -> opera9
@@ -84,18 +92,23 @@
8492
return 'opera9'; // use e.message
8593
}
8694
return 'opera10a'; // use e.stacktrace
87-
} else if (e.message && e.stack && e.stacktrace) {
95+
}
96+
97+
if (e.message && e.stack && e.stacktrace) {
8898
// e.stacktrace && e.stack -> opera10b
8999
if (e.stacktrace.indexOf("called from line") < 0) {
90100
return 'opera10b'; // use e.stacktrace, format differs from 'opera10a'
91101
}
92102
// e.stacktrace && e.stack -> opera11
93103
return 'opera11'; // use e.stacktrace, format differs from 'opera10a', 'opera10b'
94-
} else if (e.stack && !e.fileName) {
104+
}
105+
106+
if (e.stack && !e.fileName) {
95107
// Chrome 27 does not have e.arguments as earlier versions,
96108
// but still does not have e.fileName as Firefox
97109
return 'chrome';
98110
}
111+
99112
return 'other';
100113
},
101114

0 commit comments

Comments
 (0)