Skip to content

Commit 34367b6

Browse files
committed
removed unneeded "else" statements
As every if have return statement else are not needed
1 parent 96c41b3 commit 34367b6

File tree

1 file changed

+19
-6
lines changed

1 file changed

+19
-6
lines changed

stacktrace.js

Lines changed: 19 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -68,13 +68,21 @@
6868
mode: function(e) {
6969
if (e['arguments'] && e.stack) {
7070
return 'chrome';
71-
} else if (e.stack && e.sourceURL) {
71+
}
72+
73+
if (e.stack && e.sourceURL) {
7274
return 'safari';
73-
} else if (e.stack && e.number) {
75+
}
76+
77+
if (e.stack && e.number) {
7478
return 'ie';
75-
} else if (e.stack && e.fileName) {
79+
}
80+
81+
if (e.stack && e.fileName) {
7682
return 'firefox';
77-
} else if (e.message && e['opera#sourceloc']) {
83+
}
84+
85+
if (e.message && e['opera#sourceloc']) {
7886
// e.message.indexOf("Backtrace:") > -1 -> opera9
7987
// 'opera#sourceloc' in e -> opera9, opera10a
8088
// !e.stacktrace -> opera9
@@ -86,18 +94,23 @@
8694
return 'opera9'; // use e.message
8795
}
8896
return 'opera10a'; // use e.stacktrace
89-
} else if (e.message && e.stack && e.stacktrace) {
97+
}
98+
99+
if (e.message && e.stack && e.stacktrace) {
90100
// e.stacktrace && e.stack -> opera10b
91101
if (e.stacktrace.indexOf("called from line") < 0) {
92102
return 'opera10b'; // use e.stacktrace, format differs from 'opera10a'
93103
}
94104
// e.stacktrace && e.stack -> opera11
95105
return 'opera11'; // use e.stacktrace, format differs from 'opera10a', 'opera10b'
96-
} else if (e.stack && !e.fileName) {
106+
}
107+
108+
if (e.stack && !e.fileName) {
97109
// Chrome 27 does not have e.arguments as earlier versions,
98110
// but still does not have e.fileName as Firefox
99111
return 'chrome';
100112
}
113+
101114
return 'other';
102115
},
103116

0 commit comments

Comments
 (0)