Skip to content

Commit 1c62abb

Browse files
committed
Reuse StackTraceGPS instance where we can to avoid duplicate network requests for the same resource. Should fix #157
1 parent beb2e52 commit 1c62abb

File tree

5 files changed

+9
-8
lines changed

5 files changed

+9
-8
lines changed

dist/stacktrace-with-promises-and-json-polyfills.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/stacktrace-with-promises-and-json-polyfills.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/stacktrace.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/stacktrace.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

stacktrace.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@
1818
(stackframe.functionName || '').indexOf('ErrorStackParser$$') === -1 &&
1919
(stackframe.functionName || '').indexOf('StackTraceGPS$$') === -1 &&
2020
(stackframe.functionName || '').indexOf('StackGenerator$$') === -1;
21-
}
21+
},
22+
sourceCache: {}
2223
};
2324

2425
/**
@@ -78,6 +79,7 @@
7879
*/
7980
fromError: function StackTrace$$fromError(error, opts) {
8081
opts = _merge(_options, opts);
82+
var gps = new StackTraceGPS(opts);
8183
return new Promise(function(resolve) {
8284
var stackframes = ErrorStackParser.parse(error);
8385
if (typeof opts.filter === 'function') {
@@ -89,8 +91,7 @@
8991
resolve(sf);
9092
}
9193

92-
new StackTraceGPS(opts).pinpoint(sf)
93-
.then(resolve, resolveOriginal)['catch'](resolveOriginal);
94+
gps.pinpoint(sf).then(resolve, resolveOriginal)['catch'](resolveOriginal);
9495
});
9596
})));
9697
}.bind(this));

0 commit comments

Comments
 (0)