Parse Node stacktraces correctly for filenames with spaces

Author: bengourley

error-stack-parser.js

@@ -58,8 +58,18 @@
                     // Throw away eval information until we implement stacktrace.js/stackframe#8
                     line = line.replace(/eval code/g, 'eval').replace(/(\(eval at [^\()]*)|(\)\,.*$)/g, '');
                 }
-                var tokens = line.replace(/^\s+/, '').replace(/\(eval code/g, '(').split(/\s+/).slice(1);
-                var locationParts = this.extractLocation(tokens.pop());
+                var sanitizedLine = line.replace(/^\s+/, '').replace(/\(eval code/g, '(');
+
+                // capture and preseve the parenthesized location "(/foo/my bar.js:12:87)" in
+                // case it has spaces in it, as the string is split on \s+ later on
+                var location = sanitizedLine.match(/ (\((.+):(\d+):(\d+)\)$)/);
+
+                // remove the parenthesized location from the line, if it was matched
+                sanitizedLine = location ? sanitizedLine.replace(location[0], '') : sanitizedLine;
+
+                var tokens = sanitizedLine.split(/\s+/).slice(1);
+                // if a location was matched, pass it to extractLocation() otherwise pop the last token
+                var locationParts = this.extractLocation(location ? location[1] : tokens.pop());
                 var functionName = tokens.join(' ') || undefined;
                 var fileName = ['eval', '<anonymous>'].indexOf(locationParts[0]) > -1 ? undefined : locationParts[0];
 

spec/error-stack-parser-spec.js

@@ -234,5 +234,13 @@ describe('ErrorStackParser', function() {
             expect(stackframes[0].lineNumber).toBeUndefined();
             expect(stackframes[0].columnNumber).toBeUndefined();
         });
+
+        it('should handle spaces in Node.js stacks', function() {
+            var stackframes = unit.parse(CapturedExceptions.NODE_WITH_SPACES);
+            expect(stackframes.length).toBe(7);
+            expect(stackframes[0].fileName).toEqual('/var/app/scratch/my project/index.js');
+            expect(stackframes[0].lineNumber).toBe(2);
+            expect(stackframes[0].columnNumber).toBe(9);
+        });
     });
 });

spec/fixtures/captured-errors.js

@@ -383,3 +383,17 @@ CapturedExceptions.EDGE_20_NESTED_EVAL = {
     '  at speak (http://localhost:8080/file.js:25:17)\n' +
     '  at Global code (http://localhost:8080/file.js:32:9)'
 };
+
+CapturedExceptions.NODE_WITH_SPACES = {
+  name: 'Error',
+  message: '',
+  stack: 'Error\n    at Object.<anonymous> ' +
+    '(/var/app/scratch/my ' +
+    'project/index.js:2:9)\n    at Module._compile ' +
+    '(internal/modules/cjs/loader.js:774:30)\n    at ' +
+    'Object.Module._extensions..js (internal/modules/cjs/loader.js:785:10)\n   ' +
+    ' at Module.load (internal/modules/cjs/loader.js:641:32)\n    at ' +
+    'Function.Module._load (internal/modules/cjs/loader.js:556:12)\n    at ' +
+    'Function.Module.runMain (internal/modules/cjs/loader.js:837:10)\n    at ' +
+    'internal/main/run_main_module.js:17:11'
+};