CRC: remove extra unrelated tests, remove unrelated comments, improve comments

Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>

Author: jacinta-stacks

clarity-types/src/types/mod.rs

@@ -196,10 +196,6 @@ impl QualifiedContractIdentifier {
     pub fn parse(literal: &str) -> Result<QualifiedContractIdentifier, VmExecutionError> {
         let split: Vec<_> = literal.splitn(2, '.').collect();
         if split.len() != 2 {
-            // This `TypeParseFailure` is **unreachable** in standard Clarity VM execution.
-            // - Any qualified contract identifier with a mismatching number of '.' separators
-            // would have failed earlier during static checks at deployment or function call parsing.
-            // Only malformed input fed directly to this internal method (e.g., in unit tests) can trigger this error.
             return Err(RuntimeError::TypeParseFailure(
                 "Invalid principal literal: expected a `.` in a qualified contract name"
                     .to_string(),
@@ -304,10 +300,6 @@ impl TraitIdentifier {
     ) -> Result<(Option<StandardPrincipalData>, ContractName, ClarityName), VmExecutionError> {
         let split: Vec<_> = literal.splitn(3, '.').collect();
         if split.len() != 3 {
-            // This `TypeParseFailure` is **unreachable** in standard Clarity VM execution.
-            // - Any trait identifier with a mismatching number of '.' separators
-            // would have failed earlier during static checks at deployment or function call parsing.
-            // Only malformed input fed directly to this internal method (e.g., in unit tests) can trigger this error.
             return Err(RuntimeError::TypeParseFailure(
                 "Invalid principal literal: expected a `.` in a qualified contract name"
                     .to_string(),

stackslib/src/chainstate/tests/runtime_tests.rs

@@ -403,6 +403,7 @@ fn arithmetic_pow_neg() {
 /// Error: [`RuntimeError::Arithmetic`]
 /// Caused by: calling nlogn with n = 0
 /// Outcome: block accepted.
+/// Note: Returns a [`clarity::vm::analysis::CheckErrorKind::CostComputationFailed`] which wrapps the underlying [`RuntimeError::Arithmetic`] error.
 #[test]
 fn arithmetic_zero_n_log_n() {
     contract_call_consensus_test!(
@@ -614,6 +615,7 @@ fn defunct_pox_contracts() {
     let mut blocks = vec![];
     // Attempt to mine each transaction in a diff block
     for tx in [
+        // These pox lockups should fail
         make_pox_lockup(
             &sender_sk,
             nonce,
@@ -639,6 +641,7 @@ fn defunct_pox_contracts() {
             lock_period,
             height,
         ),
+        // This final lockup should succeed until we upgrade our pox contract
         make_pox_4_lockup(
             &sender_sk,
             nonce + 3,
@@ -664,90 +667,6 @@ fn defunct_pox_contracts() {
     insta::assert_ron_snapshot!(results);
 }
 
-/// Error: ERR_STACKING_ALREADY_STACKED
-/// Caused by: calling `stack-stx` when the caller already has an active lock.
-/// Outcome: block accepted
-#[test]
-fn pox_already_locked() {
-    assert_eq!(
-        StacksEpochId::latest(),
-        StacksEpochId::Epoch33,
-        "Test may need to update its pox contract call"
-    );
-    let sender_sk = StacksPrivateKey::from_hex(SK_1).unwrap();
-    let address = to_addr(&sender_sk);
-    let principal: PrincipalData = address.clone().into();
-    let hash_mode = AddressHashMode::SerializeP2PKH;
-    let addr_bytes = address.bytes();
-    let pox_address = PoxAddress::from_legacy(hash_mode, addr_bytes.clone());
-    let signer_key = StacksPublicKey::from_private(&sender_sk);
-    let mut nonce = 0;
-
-    let lock_amount = TestStacker::DEFAULT_STACKER_AMOUNT;
-    let addr_bytes = address.bytes();
-    let lock_period = 1;
-    let auth_id = 1;
-
-    // Height can be bogus; this test is not testing validity of cycle alignment.
-    let height = 0;
-
-    let initial_balances = vec![(principal.clone(), u64::try_from(lock_amount).unwrap() * 2)];
-
-    let signature = make_signer_key_signature(
-        &pox_address,
-        &sender_sk,
-        6,
-        &Pox4SignatureTopic::StackStx,
-        1,
-        u128::MAX,
-        auth_id,
-    );
-
-    // First transaction: succeeds → lock is created.
-    let tx1 = make_pox_4_lockup(
-        &sender_sk,
-        nonce,
-        lock_amount,
-        &pox_address,
-        1,
-        &signer_key,
-        48,
-        Some(signature.clone()),
-        u128::MAX,
-        auth_id,
-    );
-    nonce += 1;
-
-    // Second transaction: *same address, overlapping period* → ERR_STACKING_ALREADY_STACKED.
-    let tx2 = make_pox_4_lockup(
-        &sender_sk,
-        nonce,
-        lock_amount,
-        &pox_address,
-        1,
-        &signer_key,
-        48,
-        Some(signature),
-        u128::MAX,
-        auth_id,
-    );
-
-    let blocks = vec![
-        TestBlock {
-            transactions: vec![tx1],
-        },
-        TestBlock {
-            transactions: vec![tx2],
-        },
-    ];
-
-    let epoch_blocks = HashMap::from([(StacksEpochId::latest(), blocks)]);
-
-    let results = ConsensusTest::new(function_name!(), initial_balances, epoch_blocks).run();
-
-    insta::assert_ron_snapshot!(results);
-}
-
 /// Error: [`RuntimeError::BlockTimeNotAvailable`]
 /// Caused by: attempting to retrieve the stacks-block-time from a pre-3.3 height
 /// Outcome: block accepted