Made it work for non identifiables

StressTestExample is broken

Author: MiaKoring

Sources/SwiftCrossUI/Views/Button.swift

@@ -1,3 +1,5 @@
+import Foundation
+
 /// A control that initiates an action.
 public struct Button: Sendable {
     /// The label to show on the button.

Sources/SwiftCrossUI/Views/ForEach.swift

@@ -255,7 +255,6 @@ extension ForEach: TypeSafeView, View where Child: View {
         //   a huge issue, but definitely something to keep an eye on.
         var layoutableChildren: [LayoutSystem.LayoutableChild] = []
 
-        let oldNodes = children.nodes
         let oldMap = children.nodeIdentifierMap
         let oldIdentifiers = children.identifiers
         let identifiersStart = oldIdentifiers.startIndex
@@ -269,11 +268,11 @@ extension ForEach: TypeSafeView, View where Child: View {
         // rendered in the correct order.
         var requiresOngoingReinsertion = false
 
-        for (i, element) in elements.enumerated() {
+        for element in elements {
             let childContent = child(element)
             let node: AnyViewGraphNode<Child>
 
-            if let oldNode = oldMap[element.id] {
+            if let oldNode = oldMap[element[keyPath: idKeyPath]] {
                 node = oldNode
 
                 // Checks if there is a preceding item that was not preceding in
@@ -284,7 +283,8 @@ extension ForEach: TypeSafeView, View where Child: View {
                     requiresOngoingReinsertion
                     || {
                         guard
-                            let ownOldIndex = oldIdentifiers.firstIndex(of: element.id)
+                            let ownOldIndex = oldIdentifiers.firstIndex(
+                                of: element[keyPath: idKeyPath])
                         else { return false }
 
                         let subset = oldIdentifiers[identifiersStart..<ownOldIndex]
@@ -297,7 +297,7 @@ extension ForEach: TypeSafeView, View where Child: View {
                 }
             } else {
                 // New Items need ongoing reinsertion to get
-                // displayed at the correct location.
+                // displayed at the correct locat ion.
                 requiresOngoingReinsertion = true
                 node = AnyViewGraphNode(
                     for: childContent,

Sources/SwiftCrossUI/Views/Menu.swift

@@ -26,11 +26,11 @@ public struct Menu: Sendable {
         ResolvedMenu(
             items: items.map { item in
                 switch item {
-                    case .button(let button):
+                    case .button(let button, _):
                         .button(button.label, button.action)
-                    case .text(let text):
+                    case .text(let text, _):
                         .button(text.string, nil)
-                    case .submenu(let submenu):
+                    case .submenu(let submenu, _):
                         .submenu(submenu.resolve())
                 }
             }

Sources/SwiftCrossUI/Views/MenuItem.swift

@@ -1,6 +1,33 @@
 /// An item of a ``Menu`` or ``CommandMenu``.
 public enum MenuItem: Sendable {
-    case button(Button)
-    case text(Text)
-    case submenu(Menu)
+    case button(Button, Int? = nil)
+    case text(Text, Int? = nil)
+    case submenu(Menu, Int? = nil)
+}
+
+extension MenuItem: Hashable {
+    public static func == (lhs: MenuItem, rhs: MenuItem) -> Bool {
+        lhs.hashValue == rhs.hashValue
+    }
+
+    public func hash(into hasher: inout Hasher) {
+        hasher.combine(
+            {
+                switch self {
+                    case .button(_, let int), .text(_, let int), .submenu(_, let int):
+                        return int ?? 0
+                }
+            }())
+    }
+
+    package func addingIDIfNeeded(id: Int) -> Self {
+        switch self {
+            case .button(let button, let int):
+                return .button(button, int ?? id)
+            case .text(let text, let int):
+                return .text(text, int ?? id)
+            case .submenu(let menu, let int):
+                return .submenu(menu, int ?? id)
+        }
+    }
 }