Add test

Author: marickvantuil

src/TaskHandler.php

@@ -189,6 +189,10 @@ private function getRetryUntilTimestamp(CloudTasksJob $job)
             return null;
         }
 
+        if (! $this->retryConfig->hasMaxRetryDuration()) {
+            return null;
+        }
+
         $maxDurationInSeconds = $this->retryConfig->getMaxRetryDuration()->getSeconds();
 
         $firstAttemptTimestamp = $attempt->getDispatchTime()->toDateTime()->getTimestamp();

tests/TaskHandlerTest.php

@@ -56,23 +56,29 @@ protected function setUp(): void
 
         // Ensure we don't fetch the Queue name and attempts each test...
         $cloudTasksClient->shouldReceive('queueName')->andReturn('my-queue');
-        $cloudTasksClient->shouldReceive('getQueue')->andReturn(new class {
-            public function getRetryConfig() {
-                return new class {
-                    public function getMaxAttempts() {
-                        return 3;
-                    }
-
-                    public function getMaxRetryDuration() {
-                        return new class {
-                            public function getSeconds() {
-                                return 30;
-                            }
-                        };
-                    }
-                };
-            }
-        });
+        $cloudTasksClient->shouldReceive('getQueue')
+            ->byDefault()
+            ->andReturn(new class {
+                public function getRetryConfig() {
+                    return new class {
+                        public function getMaxAttempts() {
+                            return 3;
+                        }
+
+                        public function hasMaxRetryDuration() {
+                            return true;
+                        }
+
+                        public function getMaxRetryDuration() {
+                            return new class {
+                                public function getSeconds() {
+                                    return 30;
+                                }
+                            };
+                        }
+                    };
+                }
+            });
         $cloudTasksClient->shouldReceive('taskName')->andReturn('FakeTaskName');
         $cloudTasksClient->shouldReceive('getTask')->byDefault()->andReturn(new class {
             public function getFirstAttempt() {
@@ -245,6 +251,37 @@ public function getFirstAttempt() {
         $this->cloudTasksClient->shouldHaveReceived('deleteTask')->once();
     }
 
+    /** @test */
+    public function test_unlimited_max_attempts()
+    {
+        $this->cloudTasksClient->shouldReceive('getQueue')
+            ->byDefault()
+            ->andReturn(new class {
+                public function getRetryConfig() {
+                    return new class {
+                        public function getMaxAttempts() {
+                            return -1;
+                        }
+
+                        public function hasMaxRetryDuration() {
+                            return false;
+                        }
+                    };
+                }
+            });
+
+        for ($i = 0; $i < 50; $i++) {
+            $this->request->headers->add(['X-CloudTasks-TaskRetryCount' => $i]);
+
+            rescue(function () {
+                $this->handler->handle($this->failingJob());
+            });
+
+            $this->cloudTasksClient->shouldNotHaveReceived('deleteTask');
+        }
+
+    }
+
     private function simpleJob()
     {
         return json_decode(file_get_contents(__DIR__ . '/Support/test-job-payload.json'), true);