Skip to content

Conversation

@stackit-pipeline
Copy link
Contributor

Generated from GitHub run 19494898187

@rubenhoenle
Copy link
Member

superseded by #2566

@rubenhoenle rubenhoenle deleted the generator-bot-19494898187/iaas branch November 25, 2025 10:55
@rubenhoenle rubenhoenle restored the generator-bot-19494898187/iaas branch November 25, 2025 10:56
@rubenhoenle rubenhoenle reopened this Nov 25, 2025
@rubenhoenle rubenhoenle self-assigned this Nov 26, 2025
@rubenhoenle rubenhoenle force-pushed the generator-bot-19494898187/iaas branch 2 times, most recently from 0d992a0 to 1b9c6c4 Compare December 1, 2025 10:47
cgoetz-inovex
cgoetz-inovex previously approved these changes Dec 1, 2025
Copy link

@cgoetz-inovex cgoetz-inovex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

while True:
list_regions_resp = client.list_network_area_regions(organization_id, network_area_id)
if len(list_regions_resp.regions) > 1:
break

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
break
break
time.sleep(1)

we could add a sleep here to reduce the amount of requests

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants