Skip to content

Commit 47db483

Browse files
author
Yago Carlos Fernandez Gou
committed
Address review: make json and yaml valid for update and delete + remove example
1 parent cf8affe commit 47db483

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

internal/cmd/intake/runner/delete/delete.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ func NewDeleteCmd(p *params.CmdParams) *cobra.Command {
6565
return fmt.Errorf("delete Intake Runner: %w", err)
6666
}
6767

68-
p.Printer.Outputf("Deletion request for Intake Runner %q sent successfully.\n", model.RunnerId)
6968
return nil
7069
},
7170
}

internal/cmd/intake/runner/update/update.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,6 @@ func NewUpdateCmd(p *params.CmdParams) *cobra.Command {
5656
examples.NewExample(
5757
`Update the message capacity limits for an Intake Runner with ID "xxx"`,
5858
`$ stackit intake runner update xxx --max-message-size-kib 2000 --max-messages-per-hour 10000`),
59-
examples.NewExample(
60-
`Clear the labels of an Intake Runner with ID "xxx" by providing an empty value`,
61-
`$ stackit intake runner update xxx --labels ""`),
6259
),
6360
RunE: func(cmd *cobra.Command, args []string) error {
6461
ctx := context.Background()
@@ -98,7 +95,7 @@ func configureFlags(cmd *cobra.Command) {
9895
cmd.Flags().Int64(maxMessageSizeKiBFlag, 0, "Maximum message size in KiB. Note: Overall message capacity cannot be decreased.")
9996
cmd.Flags().Int64(maxMessagesPerHourFlag, 0, "Maximum number of messages per hour. Note: Overall message capacity cannot be decreased.")
10097
cmd.Flags().String(descriptionFlag, "", "Description")
101-
cmd.Flags().StringToString(labelFlag, nil, "Labels in key=value format. To clear all labels, provide an empty string, e.g. --labels \"\"")
98+
cmd.Flags().StringToString(labelFlag, nil, `Labels in key=value format, separated by commas. Example: --labels "key1=value1,key2=value2".`)
10299
}
103100

104101
func parseInput(p *print.Printer, cmd *cobra.Command, inputArgs []string) (*inputModel, error) {

0 commit comments

Comments
 (0)