feat: use wait_for_connection

Previously we have needed to use `command` to perform pings from the
control host, however, this is no longer required as we can use
`wait_for_connection` against a full inventory.

Author: jackhodgkiss

ansible/deploy-openstack-config.yml

@@ -17,20 +17,10 @@
           - vxlan_vni != None
         fail_msg: "Please provide a VXLAN VNI. A unique value from 1 to 100,000."
 
-    - name: Ensure Ansible host is reachable
-      ansible.builtin.wait_for_connection:
-
     - name: Gather facts about the host
       ansible.builtin.setup:
-
-    - name: Ensure hosts are reachable
-      ansible.builtin.command:
-        cmd: "ping -c 1 -w 2 {{ item.value }}"
-      loop: "{{ (lookup('file', 'files/admin-oc-networks.yml') | from_yaml).admin_oc_ips | dict2items }}"
-      changed_when: false
-      register: ping_results
-      retries: 3
-      until: ping_results is succeeded
+        gather_subset:
+          - user_dir
 
     - name: Ensure git is present
       ansible.builtin.package:

ansible/fix-homedir-ownership.yml

@@ -1,14 +1,22 @@
 ---
 - name: Fix Home Directory Ownership
   hosts: all
-  gather_facts: true
+  gather_facts: false
   vars:
     # At the time of running this playbook the home directory is not owned by the user.
     # Therefore, we will not be permitted to store the Ansible temporary directory in the home folder.
     # This must be relocated to some where that can be written to by the remote user.
     ansible_remote_tmp: "/tmp/ansible"
   tasks:
-    - name: Ensure homedir is owned by cloud-user # noqa: no-changed-when
+    - name: Ensure hosts are reachable
+      ansible.builtin.wait_for_connection:
+
+    - name: Gather the home directory of the user
+      ansible.builtin.setup:
+        gather_subset:
+          - user_dir
+
+    - name: Ensure homedir is owned by {{ ansible_user }}
       ansible.builtin.file:
         dest: "{{ ansible_env.HOME }}"
         state: directory