Replace old syntax "with_items" with "loop"

See https://docs.ansible.com/ansible/latest/user_guide/playbooks_loops.html

Author: raspbeguy

tasks/install.yml

@@ -38,7 +38,7 @@
   package:
     name: "{{ package }}"
     state: present
-  with_items: "{{ libvirt_host_qemu_emulators }}"
+  loop: "{{ libvirt_host_qemu_emulators | flatten(levels=1) }}"
   # NOTE(mgoddard): CentOS 8 does not provide separate packages per-emulator.
   when: ansible_os_family != "RedHat" or ansible_distribution_major_version | int == 7
   register: result

tasks/pools.yml

@@ -7,15 +7,15 @@
     mode: "{{ item.mode|int(base=8) }}"
     state: directory
   when: item.type == "dir"
-  with_items: "{{ libvirt_host_pools }}"
+  loop: "{{ libvirt_host_pools | flatten(levels=1) }}"
   become: True
 
 - name: Ensure libvirt LVM storage pool directories exist
   lvg:
     vg: "{{ item.source }}"
     pvs: "{{ item.pvs }}"
   when: item.type in ["lvm2", "logical"]
-  with_items: "{{ libvirt_host_pools }}"
+  loop: "{{ libvirt_host_pools | flatten(levels=1) }}"
   become: True
 
 - name: Ensure libvirt storage pools are defined
@@ -24,21 +24,21 @@
     command: define
     xml: "{{ item.xml | default(lookup('template', 'pool.xml.j2')) }}"
     uri: "{{ libvirt_host_uri | default(omit, true) }}"
-  with_items: "{{ libvirt_host_pools }}"
+  loop: "{{ libvirt_host_pools | flatten(levels=1) }}"
   become: True
 
 - name: Ensure libvirt storage pools are active
   virt_pool:
     name: "{{ item.name }}"
     state: active
     uri: "{{ libvirt_host_uri | default(omit, true) }}"
-  with_items: "{{ libvirt_host_pools }}"
+  loop: "{{ libvirt_host_pools | flatten(levels=1) }}"
   become: True
 
 - name: Ensure libvirt storage pools are started on boot
   virt_pool:
     name: "{{ item.name }}"
     autostart: yes
     uri: "{{ libvirt_host_uri | default(omit, true) }}"
-  with_items: "{{ libvirt_host_pools }}"
+  loop: "{{ libvirt_host_pools | flatten(levels=1) }}"
   become: True