-
Notifications
You must be signed in to change notification settings - Fork 2
feat(native): add toHaveStyle #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ACR1209
wants to merge
6
commits into
feat/native-to-have-prop
Choose a base branch
from
feat/native-to-have-style
base: feat/native-to-have-prop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2e86fbb
feat(native): add toHaveStyle matcher
ACR1209 e504a05
docs(native): add doc comment for toHaveStyle function
ACR1209 728f1e3
docs(native): fix linting issues
ACR1209 52f0b5f
refactor(native): remove styles.ts file and merge with helpers.ts
ACR1209 6421544
refactor(native): improve style printing
ACR1209 8ae6c51
style(native): fix linting issues
ACR1209 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import { ImageStyle, StyleProp, TextStyle, ViewStyle } from "react-native"; | ||
|
|
||
| /** | ||
| * Type representing a style that can be applied to a React Native component. | ||
| * It can be a style for text, view, or image components. | ||
| */ | ||
| export type Style = TextStyle | ViewStyle | ImageStyle; | ||
|
|
||
| /** | ||
| * Type for a style prop that can be applied to a React Native component. | ||
| * It can be a single style or an array of styles. | ||
| */ | ||
| export type AssertiveStyle = StyleProp<Style>; | ||
|
|
||
| /** | ||
| * Type representing a style object when flattened. | ||
| * It is a record where the keys are strings and the values can be of any type. | ||
| */ | ||
| export type StyleObject = Record<string, unknown>; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we allowing an array of styling objects in here? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because you can have an array of styles on React Native for styling 😄
Snippet from the Style docs of supported style prop values