move serializer to core from db logic

Author: jonhealy1

stac_fastapi/elasticsearch/stac_fastapi/elasticsearch/core.py

@@ -52,7 +52,11 @@ class CoreClient(AsyncBaseCoreClient):
     async def all_collections(self, **kwargs) -> Collections:
         """Read all collections from the database."""
         base_url = str(kwargs["request"].base_url)
-        collection_list = await self.database.get_all_collections(base_url=base_url)
+        collection_list = await self.database.get_all_collections()
+        collection_list =  [
+            self.collection_serializer.db_to_stac(c, base_url=base_url)
+            for c in collection_list
+        ]
 
         links = [
             {

stac_fastapi/elasticsearch/stac_fastapi/elasticsearch/database_logic.py

@@ -66,15 +66,13 @@ class DatabaseLogic:
 
     """CORE LOGIC"""
 
-    async def get_all_collections(self, base_url: str) -> List[Collection]:
+    async def get_all_collections(self) -> List[Collection]:
         """Database logic to retrieve a list of all collections."""
         # https://github.com/stac-utils/stac-fastapi-elasticsearch/issues/65
         # collections should be paginated, but at least return more than the default 10 for now
         collections = await self.client.search(index=COLLECTIONS_INDEX, size=1000)
-
         return [
-            self.collection_serializer.db_to_stac(c["_source"], base_url=base_url)
-            for c in collections["hits"]["hits"]
+            c["_source"] for c in collections["hits"]["hits"]
         ]
 
     async def get_one_item(self, collection_id: str, item_id: str) -> Dict: