Fix exhaustive memory consumption (#110)

staabm · web-flow · commit 2715e6d792de · 2024-09-16T17:02:14.000+02:00
Co-authored-by: staabm &lt;staabm@users.noreply.github.com&gt;
diff --git a/src/TodoByTicketCollector.php b/src/TodoByTicketCollector.php
@@ -55,7 +55,12 @@ public function processNode(Node $node, Scope $scope)
             }
         }
 
-        return $tickets;
+        // don't return empty array so we don't pollute the result cache
+        // see https://github.com/phpstan/phpstan/discussions/11701#discussioncomment-10660711
+        if ([] !== $tickets) {
+            return $tickets;
+        }
+        return null;
     }
 
     private function createPattern(): string

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,12 @@ public function processNode(Node $node, Scope $scope)`
`55`	`55`	`}`
`56`	`56`	`}`
`57`	`57`
`58`		`- return $tickets;`
	`58`	`+ // don't return empty array so we don't pollute the result cache`
	`59`	`+ // see https://github.com/phpstan/phpstan/discussions/11701#discussioncomment-10660711`
	`60`	`+ if ([] !== $tickets) {`
	`61`	`+ return $tickets;`
	`62`	`+ }`
	`63`	`+ return null;`
`59`	`64`	`}`
`60`	`65`
`61`	`66`	`private function createPattern(): string`