Allow for a small marging when verifying whether configured timeout was respected.

drieseng · drieseng · commit 008556205b8d · 2020-12-31T11:37:18.000+01:00
diff --git a/src/Renci.SshNet.Tests/Classes/Connection/DirectConnectorTest_Connect_ConnectionRefusedByServer.cs b/src/Renci.SshNet.Tests/Classes/Connection/DirectConnectorTest_Connect_ConnectionRefusedByServer.cs
@@ -77,7 +77,8 @@ public void ConnectShouldHaveRespectedTimeout()
                                           _stopWatch.ElapsedMilliseconds,
                                           _connectionInfo.Timeout.TotalMilliseconds);
 
-            Assert.IsTrue(_stopWatch.ElapsedMilliseconds < _connectionInfo.Timeout.TotalMilliseconds, errorText);
+            // Compare elapsed time with configured timeout, allowing for a margin of error
+            Assert.IsTrue(_stopWatch.ElapsedMilliseconds < _connectionInfo.Timeout.TotalMilliseconds + 100, errorText);
         }
 
         [TestMethod]
diff --git a/src/Renci.SshNet.Tests/Classes/Connection/DirectConnectorTest_Connect_ConnectionSucceeded.cs b/src/Renci.SshNet.Tests/Classes/Connection/DirectConnectorTest_Connect_ConnectionSucceeded.cs
@@ -88,7 +88,8 @@ public void ConnectShouldHaveRespectedTimeout()
                                           _stopWatch.ElapsedMilliseconds,
                                           _connectionInfo.Timeout.TotalMilliseconds);
 
-            Assert.IsTrue(_stopWatch.ElapsedMilliseconds < (_connectionInfo.Timeout.TotalMilliseconds + 100), errorText);
+            // Compare elapsed time with configured timeout, allowing for a margin of error
+            Assert.IsTrue(_stopWatch.ElapsedMilliseconds < _connectionInfo.Timeout.TotalMilliseconds + 100, errorText);
         }
 
         [TestMethod]
diff --git a/src/Renci.SshNet.Tests/Classes/Connection/DirectConnectorTest_Connect_TimeoutConnectingToServer.cs b/src/Renci.SshNet.Tests/Classes/Connection/DirectConnectorTest_Connect_TimeoutConnectingToServer.cs
@@ -81,8 +81,9 @@ public void ConnectShouldHaveRespectedTimeout()
                                           _stopWatch.ElapsedMilliseconds,
                                           _connectionInfo.Timeout.TotalMilliseconds);
 
-            Assert.IsTrue(_stopWatch.ElapsedMilliseconds >= _connectionInfo.Timeout.TotalMilliseconds, errorText);
-            Assert.IsTrue(_stopWatch.ElapsedMilliseconds < (_connectionInfo.Timeout.TotalMilliseconds + 100), errorText);
+            // Compare elapsed time with configured timeout, allowing for a margin of error
+            Assert.IsTrue(_stopWatch.ElapsedMilliseconds >= _connectionInfo.Timeout.TotalMilliseconds - 10, errorText);
+            Assert.IsTrue(_stopWatch.ElapsedMilliseconds < _connectionInfo.Timeout.TotalMilliseconds + 100, errorText);
         }
 
         [TestMethod]
diff --git a/src/Renci.SshNet.Tests/Classes/Connection/HttpConnectorTest_Connect_ConnectionToProxyRefused.cs b/src/Renci.SshNet.Tests/Classes/Connection/HttpConnectorTest_Connect_ConnectionToProxyRefused.cs
@@ -85,7 +85,8 @@ public void ConnectShouldHaveRespectedTimeout()
                                           _stopWatch.ElapsedMilliseconds,
                                           _connectionInfo.Timeout.TotalMilliseconds);
 
-            Assert.IsTrue(_stopWatch.ElapsedMilliseconds < _connectionInfo.Timeout.TotalMilliseconds, errorText);
+            // Compare elapsed time with configured timeout, allowing for a margin of error
+            Assert.IsTrue(_stopWatch.ElapsedMilliseconds < _connectionInfo.Timeout.TotalMilliseconds + 100, errorText);
         }
 
         [TestMethod]
diff --git a/src/Renci.SshNet.Tests/Classes/Connection/HttpConnectorTest_Connect_TimeoutConnectingToProxy.cs b/src/Renci.SshNet.Tests/Classes/Connection/HttpConnectorTest_Connect_TimeoutConnectingToProxy.cs
@@ -88,8 +88,9 @@ public void ConnectShouldHaveRespectedTimeout()
                                           _stopWatch.ElapsedMilliseconds,
                                           _connectionInfo.Timeout.TotalMilliseconds);
 
-            Assert.IsTrue(_stopWatch.ElapsedMilliseconds >= _connectionInfo.Timeout.TotalMilliseconds, errorText);
-            Assert.IsTrue(_stopWatch.ElapsedMilliseconds < (_connectionInfo.Timeout.TotalMilliseconds + 100), errorText);
+            // Compare elapsed time with configured timeout, allowing for a margin of error
+            Assert.IsTrue(_stopWatch.ElapsedMilliseconds >= _connectionInfo.Timeout.TotalMilliseconds - 10, errorText);
+            Assert.IsTrue(_stopWatch.ElapsedMilliseconds < _connectionInfo.Timeout.TotalMilliseconds + 100, errorText);
         }
 
         [TestMethod]
diff --git a/src/Renci.SshNet.Tests/Classes/Connection/HttpConnectorTest_Connect_TimeoutReadingHttpContent.cs b/src/Renci.SshNet.Tests/Classes/Connection/HttpConnectorTest_Connect_TimeoutReadingHttpContent.cs
@@ -135,8 +135,9 @@ public void ConnectShouldHaveRespectedTimeout()
                                           _stopWatch.ElapsedMilliseconds,
                                           _connectionInfo.Timeout.TotalMilliseconds);
 
-            Assert.IsTrue(_stopWatch.ElapsedMilliseconds >= _connectionInfo.Timeout.TotalMilliseconds, errorText);
-            Assert.IsTrue(_stopWatch.ElapsedMilliseconds < (_connectionInfo.Timeout.TotalMilliseconds + 100), errorText);
+            // Compare elapsed time with configured timeout, allowing for a margin of error
+            Assert.IsTrue(_stopWatch.ElapsedMilliseconds >= _connectionInfo.Timeout.TotalMilliseconds - 10, errorText);
+            Assert.IsTrue(_stopWatch.ElapsedMilliseconds < _connectionInfo.Timeout.TotalMilliseconds + 100, errorText);
         }
 
         [TestMethod]
diff --git a/src/Renci.SshNet.Tests/Classes/Connection/HttpConnectorTest_Connect_TimeoutReadingStatusLine.cs b/src/Renci.SshNet.Tests/Classes/Connection/HttpConnectorTest_Connect_TimeoutReadingStatusLine.cs
@@ -105,8 +105,9 @@ public void ConnectShouldHaveRespectedTimeout()
                                           _stopWatch.ElapsedMilliseconds,
                                           _connectionInfo.Timeout.TotalMilliseconds);
 
-            Assert.IsTrue(_stopWatch.ElapsedMilliseconds >= _connectionInfo.Timeout.TotalMilliseconds, errorText);
-            Assert.IsTrue(_stopWatch.ElapsedMilliseconds < (_connectionInfo.Timeout.TotalMilliseconds + 100), errorText);
+            // Compare elapsed time with configured timeout, allowing for a margin of error
+            Assert.IsTrue(_stopWatch.ElapsedMilliseconds >= _connectionInfo.Timeout.TotalMilliseconds - 10, errorText);
+            Assert.IsTrue(_stopWatch.ElapsedMilliseconds < _connectionInfo.Timeout.TotalMilliseconds + 100, errorText);
         }
 
         [TestMethod]
diff --git a/src/Renci.SshNet.Tests/Classes/Connection/Socks4ConnectorTest_Connect_ConnectionToProxyRefused.cs b/src/Renci.SshNet.Tests/Classes/Connection/Socks4ConnectorTest_Connect_ConnectionToProxyRefused.cs
@@ -76,7 +76,8 @@ public void ConnectShouldHaveRespectedTimeout()
                                           _stopWatch.ElapsedMilliseconds,
                                           _connectionInfo.Timeout.TotalMilliseconds);
 
-            Assert.IsTrue(_stopWatch.ElapsedMilliseconds < _connectionInfo.Timeout.TotalMilliseconds, errorText);
+            // Compare elapsed time with configured timeout, allowing for a margin of error
+            Assert.IsTrue(_stopWatch.ElapsedMilliseconds < _connectionInfo.Timeout.TotalMilliseconds + 100, errorText);
         }
 
         [TestMethod]
diff --git a/src/Renci.SshNet.Tests/Classes/Connection/Socks4ConnectorTest_Connect_TimeoutConnectingToProxy.cs b/src/Renci.SshNet.Tests/Classes/Connection/Socks4ConnectorTest_Connect_TimeoutConnectingToProxy.cs
@@ -78,8 +78,9 @@ public void ConnectShouldHaveRespectedTimeout()
                                           _stopWatch.ElapsedMilliseconds,
                                           _connectionInfo.Timeout.TotalMilliseconds);
 
-            Assert.IsTrue(_stopWatch.ElapsedMilliseconds >= _connectionInfo.Timeout.TotalMilliseconds, errorText);
-            Assert.IsTrue(_stopWatch.ElapsedMilliseconds < (_connectionInfo.Timeout.TotalMilliseconds + 100), errorText);
+            // Compare elapsed time with configured timeout, allowing for a margin of error
+            Assert.IsTrue(_stopWatch.ElapsedMilliseconds >= _connectionInfo.Timeout.TotalMilliseconds - 10, errorText);
+            Assert.IsTrue(_stopWatch.ElapsedMilliseconds < _connectionInfo.Timeout.TotalMilliseconds + 100, errorText);
         }
 
         [TestMethod]
diff --git a/src/Renci.SshNet.Tests/Classes/Connection/Socks4ConnectorTest_Connect_TimeoutReadingDestinationAddress.cs b/src/Renci.SshNet.Tests/Classes/Connection/Socks4ConnectorTest_Connect_TimeoutReadingDestinationAddress.cs
@@ -109,8 +109,9 @@ public void ConnectShouldHaveRespectedTimeout()
                                           _stopWatch.ElapsedMilliseconds,
                                           _connectionInfo.Timeout.TotalMilliseconds);
 
-            Assert.IsTrue(_stopWatch.ElapsedMilliseconds >= _connectionInfo.Timeout.TotalMilliseconds, errorText);
-            Assert.IsTrue(_stopWatch.ElapsedMilliseconds < (_connectionInfo.Timeout.TotalMilliseconds + 100), errorText);
+            // Compare elapsed time with configured timeout, allowing for a margin of error
+            Assert.IsTrue(_stopWatch.ElapsedMilliseconds >= _connectionInfo.Timeout.TotalMilliseconds - 10, errorText);
+            Assert.IsTrue(_stopWatch.ElapsedMilliseconds < _connectionInfo.Timeout.TotalMilliseconds + 100, errorText);
         }
 
         [TestMethod]
diff --git a/src/Renci.SshNet.Tests/Classes/Connection/Socks4ConnectorTest_Connect_TimeoutReadingReplyCode.cs b/src/Renci.SshNet.Tests/Classes/Connection/Socks4ConnectorTest_Connect_TimeoutReadingReplyCode.cs
@@ -105,8 +105,9 @@ public void ConnectShouldHaveRespectedTimeout()
                                           _stopWatch.ElapsedMilliseconds,
                                           _connectionInfo.Timeout.TotalMilliseconds);
 
-            Assert.IsTrue(_stopWatch.ElapsedMilliseconds >= _connectionInfo.Timeout.TotalMilliseconds, errorText);
-            Assert.IsTrue(_stopWatch.ElapsedMilliseconds < (_connectionInfo.Timeout.TotalMilliseconds + 100), errorText);
+            // Compare elapsed time with configured timeout, allowing for a margin of error
+            Assert.IsTrue(_stopWatch.ElapsedMilliseconds >= _connectionInfo.Timeout.TotalMilliseconds - 10, errorText);
+            Assert.IsTrue(_stopWatch.ElapsedMilliseconds < _connectionInfo.Timeout.TotalMilliseconds + 100, errorText);
         }
 
         [TestMethod]
diff --git a/src/Renci.SshNet.Tests/Classes/Connection/Socks4ConnectorTest_Connect_TimeoutReadingReplyVersion.cs b/src/Renci.SshNet.Tests/Classes/Connection/Socks4ConnectorTest_Connect_TimeoutReadingReplyVersion.cs
@@ -97,8 +97,9 @@ public void ConnectShouldHaveRespectedTimeout()
                                           _stopWatch.ElapsedMilliseconds,
                                           _connectionInfo.Timeout.TotalMilliseconds);
 
-            Assert.IsTrue(_stopWatch.ElapsedMilliseconds >= _connectionInfo.Timeout.TotalMilliseconds, errorText);
-            Assert.IsTrue(_stopWatch.ElapsedMilliseconds < (_connectionInfo.Timeout.TotalMilliseconds + 100), errorText);
+            // Compare elapsed time with configured timeout, allowing for a margin of error
+            Assert.IsTrue(_stopWatch.ElapsedMilliseconds >= _connectionInfo.Timeout.TotalMilliseconds - 10, errorText);
+            Assert.IsTrue(_stopWatch.ElapsedMilliseconds < _connectionInfo.Timeout.TotalMilliseconds + 100, errorText);
         }
 
         [TestMethod]
diff --git a/src/Renci.SshNet.Tests/Classes/Connection/Socks5ConnectorTest_Connect_ConnectionToProxyRefused.cs b/src/Renci.SshNet.Tests/Classes/Connection/Socks5ConnectorTest_Connect_ConnectionToProxyRefused.cs
@@ -77,7 +77,8 @@ public void ConnectShouldHaveRespectedTimeout()
                                           _stopWatch.ElapsedMilliseconds,
                                           _connectionInfo.Timeout.TotalMilliseconds);
 
-            Assert.IsTrue(_stopWatch.ElapsedMilliseconds < _connectionInfo.Timeout.TotalMilliseconds, errorText);
+            // Compare elapsed time with configured timeout, allowing for a margin of error
+            Assert.IsTrue(_stopWatch.ElapsedMilliseconds < _connectionInfo.Timeout.TotalMilliseconds + 100, errorText);
         }
 
         [TestMethod]
diff --git a/src/Renci.SshNet.Tests/Classes/Connection/Socks5ConnectorTest_Connect_TimeoutConnectingToProxy.cs b/src/Renci.SshNet.Tests/Classes/Connection/Socks5ConnectorTest_Connect_TimeoutConnectingToProxy.cs
@@ -80,8 +80,9 @@ public void ConnectShouldHaveRespectedTimeout()
                                           _stopWatch.ElapsedMilliseconds,
                                           _connectionInfo.Timeout.TotalMilliseconds);
 
-            Assert.IsTrue(_stopWatch.ElapsedMilliseconds >= _connectionInfo.Timeout.TotalMilliseconds, errorText);
-            Assert.IsTrue(_stopWatch.ElapsedMilliseconds < (_connectionInfo.Timeout.TotalMilliseconds + 100), errorText);
+            // Compare elapsed time with configured timeout, allowing for a margin of error
+            Assert.IsTrue(_stopWatch.ElapsedMilliseconds >= _connectionInfo.Timeout.TotalMilliseconds - 10, errorText);
+            Assert.IsTrue(_stopWatch.ElapsedMilliseconds < _connectionInfo.Timeout.TotalMilliseconds + 100, errorText);
         }
 
         [TestMethod]

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,8 @@ public void ConnectShouldHaveRespectedTimeout()`
`77`	`77`	`_stopWatch.ElapsedMilliseconds,`
`78`	`78`	`_connectionInfo.Timeout.TotalMilliseconds);`
`79`	`79`
`80`		`- Assert.IsTrue(_stopWatch.ElapsedMilliseconds < _connectionInfo.Timeout.TotalMilliseconds, errorText);`
	`80`	`+ // Compare elapsed time with configured timeout, allowing for a margin of error`
	`81`	`+ Assert.IsTrue(_stopWatch.ElapsedMilliseconds < _connectionInfo.Timeout.TotalMilliseconds + 100, errorText);`
`81`	`82`	`}`
`82`	`83`
`83`	`84`	`[TestMethod]`
Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,8 @@ public void ConnectShouldHaveRespectedTimeout()`
`88`	`88`	`_stopWatch.ElapsedMilliseconds,`
`89`	`89`	`_connectionInfo.Timeout.TotalMilliseconds);`
`90`	`90`
`91`		`- Assert.IsTrue(_stopWatch.ElapsedMilliseconds < (_connectionInfo.Timeout.TotalMilliseconds + 100), errorText);`
	`91`	`+ // Compare elapsed time with configured timeout, allowing for a margin of error`
	`92`	`+ Assert.IsTrue(_stopWatch.ElapsedMilliseconds < _connectionInfo.Timeout.TotalMilliseconds + 100, errorText);`
`92`	`93`	`}`
`93`	`94`
`94`	`95`	`[TestMethod]`
Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,8 @@ public void ConnectShouldHaveRespectedTimeout()`
`85`	`85`	`_stopWatch.ElapsedMilliseconds,`
`86`	`86`	`_connectionInfo.Timeout.TotalMilliseconds);`
`87`	`87`
`88`		`- Assert.IsTrue(_stopWatch.ElapsedMilliseconds < _connectionInfo.Timeout.TotalMilliseconds, errorText);`
	`88`	`+ // Compare elapsed time with configured timeout, allowing for a margin of error`
	`89`	`+ Assert.IsTrue(_stopWatch.ElapsedMilliseconds < _connectionInfo.Timeout.TotalMilliseconds + 100, errorText);`
`89`	`90`	`}`
`90`	`91`
`91`	`92`	`[TestMethod]`
Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,8 @@ public void ConnectShouldHaveRespectedTimeout()`
`76`	`76`	`_stopWatch.ElapsedMilliseconds,`
`77`	`77`	`_connectionInfo.Timeout.TotalMilliseconds);`
`78`	`78`
`79`		`- Assert.IsTrue(_stopWatch.ElapsedMilliseconds < _connectionInfo.Timeout.TotalMilliseconds, errorText);`
	`79`	`+ // Compare elapsed time with configured timeout, allowing for a margin of error`
	`80`	`+ Assert.IsTrue(_stopWatch.ElapsedMilliseconds < _connectionInfo.Timeout.TotalMilliseconds + 100, errorText);`
`80`	`81`	`}`
`81`	`82`
`82`	`83`	`[TestMethod]`